Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing spec on ruby 3.3 #401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

segiddins
Copy link
Member

Signed-off-by: Samuel Giddins [email protected]

Description:


Tasks:

  • Describe the problem / feature
  • Write tests

I will abide by the code of conduct.

@@ -2,5 +2,5 @@

# :nodoc:
module Gemstash
VERSION = "2.7.1"
VERSION = "2.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something needed to make the test pass?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but I was going to cut a new version once main is green

@olleolleolle
Copy link
Member

Weirdly, this change made jruby test fail, hm. Were they also failing without this? (Not 13h ago. Hm.)

@segiddins
Copy link
Member Author

Gem::GemNotFoundException: can't find gem gem_server_conformance (>= 0) with executable gem_server_conformance

@segiddins segiddins changed the base branch from segiddins/add-compact-index-support-for-private-sources to main November 20, 2024 16:08
@segiddins segiddins force-pushed the segiddins/fix-failing-spec-on-ruby-3.3 branch from 13f856e to 8658f8c Compare November 20, 2024 16:10
Signed-off-by: Samuel Giddins <[email protected]>
@segiddins segiddins force-pushed the segiddins/fix-failing-spec-on-ruby-3.3 branch from 8658f8c to 5445a22 Compare November 20, 2024 20:01
@olleolleolle
Copy link
Member

3.3 failed now, on: The presence of the ruby platform in the version parentheses. JRuby passed, though.

       expect(execute("gem", ["search", "-ar", "speaker"], env: env)).
         to exit_success.and_output(/speaker \(0.1.0\)/)

       expected 'gem search -ar speaker' in '/home/runner/work/gemstash/gemstash' to output:
       (?-mix:speaker \(0.1.0\))

       but instead it output:
       speaker (0.1.0 ruby)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants