Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize indexer by uploading the marshal files in a batch and pug… #3548

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

segiddins
Copy link
Member

…ing fastly as a fan-in step

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #3548 (5d1942e) into master (08bcab5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3548      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files         186      186              
  Lines        4472     4471       -1     
==========================================
- Hits         4361     4360       -1     
  Misses        111      111              
Impacted Files Coverage Δ
app/jobs/indexer.rb 100.00% <100.00%> (ø)
app/models/deletion.rb 100.00% <100.00%> (ø)
app/models/pusher.rb 94.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does seem like splitting it into three parallel jobs is going to make it faster, let's give it a shot

@simi
Copy link
Member

simi commented Jul 11, 2024

@segiddins is this still worth it?

@segiddins
Copy link
Member Author

yes still worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants