-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTML pages for OIDC resources under /profile/ #4136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
========================================
Coverage 98.89% 98.89%
========================================
Files 279 295 +16
Lines 6317 6687 +370
========================================
+ Hits 6247 6613 +366
- Misses 70 74 +4
|
3 tasks
segiddins
force-pushed
the
oidc-api-tokens
branch
2 times, most recently
from
October 18, 2023 01:11
c5fa374
to
d835e77
Compare
segiddins
force-pushed
the
oidc-api-tokens
branch
from
October 18, 2023 21:59
d835e77
to
6530384
Compare
From review w/ @indirect:
|
segiddins
force-pushed
the
oidc-api-tokens
branch
2 times, most recently
from
October 19, 2023 02:20
193a9e0
to
73bc335
Compare
segiddins
changed the title
[WIP] Add HTML pages for OIDC resources under /profile/
Add HTML pages for OIDC resources under /profile/
Oct 19, 2023
indirect
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I spotted a couple of bits I don't think you meant to include, but I think this is good to go.
segiddins
force-pushed
the
oidc-api-tokens
branch
from
October 19, 2023 23:13
73bc335
to
a2200a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4126
Available on https://oidc-api-token.rubygems.org
Demo walkthrough: https://share.cleanshot.com/2Qx4jGC5