-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization index and show #5187
Conversation
a7dd8f1
to
ac32613
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5187 +/- ##
==========================================
- Coverage 96.85% 96.72% -0.13%
==========================================
Files 456 458 +2
Lines 9529 9640 +111
==========================================
+ Hits 9229 9324 +95
- Misses 300 316 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
23b87bc
to
82e857d
Compare
8521bc3
to
d796b1b
Compare
ede3a97
to
52f2075
Compare
cc307c5
to
8b9ea90
Compare
4a509ad
to
b3c7f03
Compare
8b9ea90
to
5deb9bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, but the CodeCov is picking up that we're missing a fair amount of tests for the various paths being added.
813619a
to
b8ca5a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntax error
22eb5c9
to
cf24c19
Compare
cf24c19
to
91fbb8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, just a few minor nitpick things
|
||
get "/organizations/#{@organization.to_param}/gems" | ||
|
||
assert page.has_content? "arrakis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually need to call the page
object every time we want to test if a page has text
assert page.has_content? "arrakis" | |
assert_content "arrakis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that works in other testing contexts and not here :( I hope we can resolve this discrepancy soon.
Index is a section of the dashboard.
Show is the organization view page.
We may need to separate out the private and public view of an org, but this is a rough start.