Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization index and show #5187

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

martinemde
Copy link
Member

Index is a section of the dashboard.
Show is the organization view page.

We may need to separate out the private and public view of an org, but this is a rough start.

@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch from a7dd8f1 to ac32613 Compare October 31, 2024 20:39
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 86.79245% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (8fcd336) to head (9b0b61f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
app/views/components/card/timeline_component.rb 47.61% 11 Missing ⚠️
...pp/controllers/organizations/members_controller.rb 94.73% 2 Missing ⚠️
app/controllers/organizations_controller.rb 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5187      +/-   ##
==========================================
- Coverage   96.85%   96.72%   -0.13%     
==========================================
  Files         456      458       +2     
  Lines        9529     9640     +111     
==========================================
+ Hits         9229     9324      +95     
- Misses        300      316      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 2 times, most recently from 23b87bc to 82e857d Compare November 9, 2024 23:36
@martinemde martinemde changed the base branch from master to colby/organization-onboarding November 9, 2024 23:37
@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 2 times, most recently from 8521bc3 to d796b1b Compare November 11, 2024 05:31
@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 2 times, most recently from cc307c5 to 8b9ea90 Compare November 14, 2024 04:22
@martinemde martinemde marked this pull request as ready for review November 14, 2024 04:22
Base automatically changed from colby/organization-onboarding to master November 14, 2024 06:16
@colby-swandale colby-swandale force-pushed the martinemde/organization-show-and-index branch from 8b9ea90 to 5deb9bb Compare November 14, 2024 06:59
Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but the CodeCov is picking up that we're missing a fair amount of tests for the various paths being added.

@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 3 times, most recently from 813619a to b8ca5a1 Compare November 19, 2024 02:07
Copy link
Member Author

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error

app/views/subscriptions/index.html.erb Outdated Show resolved Hide resolved
@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 3 times, most recently from 22eb5c9 to cf24c19 Compare November 21, 2024 02:47
@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch from cf24c19 to 91fbb8a Compare November 21, 2024 02:51
Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just a few minor nitpick things

test/integration/organizations_test.rb Show resolved Hide resolved
test/integration/organizations_test.rb Show resolved Hide resolved

get "/organizations/#{@organization.to_param}/gems"

assert page.has_content? "arrakis"
Copy link
Member

@colby-swandale colby-swandale Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually need to call the page object every time we want to test if a page has text

Suggested change
assert page.has_content? "arrakis"
assert_content "arrakis"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that works in other testing contexts and not here :( I hope we can resolve this discrepancy soon.

@martinemde martinemde merged commit 9f4b969 into master Nov 22, 2024
17 checks passed
@martinemde martinemde deleted the martinemde/organization-show-and-index branch November 22, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants