Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add homepage url to user profile #5240
base: master
Are you sure you want to change the base?
Add homepage url to user profile #5240
Changes from all commits
7adad1a
29e0575
f76e318
9b52c4d
5dfe4c7
215c55e
6d7a954
62b6f6d
e76b7bb
94f31e5
922a6d0
5bd20d8
16e829f
9b2bf91
0f503b2
9cb7e45
922c274
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self: suggest the appropriate
rel=none; noreferrer
optionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like
rel="nofollow"
is what github uses on their profile links. I'm agnostic about "noreferrer" in addition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps sorry I didn't realize there was a final decision on the
rel="nofollow"
. Thank you for adding these changes :) @martinemdeCheck warning
Code scanning / CodeQL
Stored cross-site scripting Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should consider something like HackerOne's "you're about to leave this site for ...". Github appends
http://
to urls that don't have either http / https in the front, and they are probably doing more.