Update linkset homepage from gemspec only after version gets indexed #5249
+37
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current implementation, version.reload.indexed? is always false, so gems that only use spec.homepage to specify a homepage will never have a linkset created/updated Signed-off-by: Samuel Giddins <[email protected]>
segiddins
force-pushed
the
segiddins/update-linkset-homepage-from-gemspec-only-after-version-gets-indexed
branch
from
f22029d
to
1952277
Compare
martinemde
approved these changes
Nov 18, 2024
| def update_attributes_from_gem_specification!(version, spec) | ||
| Rubygem.transaction do | ||
| save! | ||
| update_versions! version, spec | ||
| update_dependencies! version, spec | ||
| update_linkset! spec if version.reload.latest? |
There was a problem hiding this comment.
Looks like we never update the linkset now. Is that expected?
| def perform(version:) | ||
| return unless version.latest? && version.indexed? | ||
|
|
||
| gem = RubygemFs.instance.get("gems/#{version.gem_file_name}") |
There was a problem hiding this comment.
This is the only job that redownloads the gem besides the content storage job. Could it just grab this info on push?
There was a problem hiding this comment.
right now we don't pass anything besides the version itself to the "after write" set of jobs, so I kept in keeping with that
segiddins
commented
Nov 19, 2024
| homepage = package.spec.homepage | ||
|
|
||
| version.rubygem.linkset ||= Linkset.new | ||
| version.rubygem.linkset.update!(home: homepage) |
There was a problem hiding this comment.
@martinemde this is where we update the linkset
|
Does this fix #4924 🎉? I think I came to a similar conclusion (linkset is never updated) in #4924 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, version.reload.indexed? is always false, so gems that only use spec.homepage to specify a homepage will never have a linkset created/updated
Signed-off-by: Samuel Giddins [email protected]