Skip to content

Commit

Permalink
fix: remove unnecessary window globals declarations (#1687)
Browse files Browse the repository at this point in the history
* fix: remove unnecessary window globals declarations

* fix: further clean up declaration files
  • Loading branch information
saikumarrs authored Apr 10, 2024
1 parent 56e34be commit 09e5ab8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 14 deletions.
5 changes: 0 additions & 5 deletions packages/analytics-js/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { RudderAnalytics } from './app/RudderAnalytics';
import type { RudderAnalyticsPreloader } from './components/preloadBuffer/types';
import type { IRudderStackGlobals } from './app/IRudderStackGlobals';

export {
type AnonymousIdOptions,
Expand All @@ -21,7 +20,6 @@ export { type LogLevel } from '@rudderstack/analytics-js-common/types/Logger';
export { type PluginName } from '@rudderstack/analytics-js-common/types/PluginsManager';
export { type IdentifyTraits } from '@rudderstack/analytics-js-common/types/traits';
export { RudderAnalytics } from './app/RudderAnalytics';
export { type IRudderStackGlobals } from './app/IRudderStackGlobals';
export {
type RudderAnalyticsPreloader,
type PreloadedEventCall,
Expand All @@ -30,8 +28,5 @@ export {
declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
}
}
2 changes: 0 additions & 2 deletions packages/analytics-js/src/types/rudderanalytics.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
RudderSnippetVersion?: string;
}
}
2 changes: 0 additions & 2 deletions packages/loading-scripts/src/types/rudderanalytics.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type {
IRudderStackGlobals,
RudderAnalytics,
PreloadedEventCall,
RudderAnalyticsPreloader,
Expand All @@ -8,7 +7,6 @@ import type {
declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
RudderSnippetVersion?: string;
Expand Down
5 changes: 0 additions & 5 deletions packages/sanity-suite/src/types/rudderanalytics.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type {
IRudderStackGlobals,
RudderAnalytics,
PreloadedEventCall,
RudderAnalyticsPreloader,
Expand All @@ -8,9 +7,5 @@ import type {
declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
RudderSnippetVersion?: string;
}
}

0 comments on commit 09e5ab8

Please sign in to comment.