feat: add dcfaid support, add test

rudderlabs · Mar 10, 2024 · 1961074 · 1961074
1 parent d025039
commit 1961074
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/packages/analytics-js-integrations/__tests__/integrations/GoogleAds/__fixtures__/data.js b/packages/analytics-js-integrations/__tests__/integrations/GoogleAds/__fixtures__/data.js
@@ -208,6 +208,10 @@ const googleAdsConfigs = [
       { conversionLabel: 'KhF2CKvCs4gYEIXBi58p', name: productAdded },
     ],
   },
+  {
+    conversionId: 'conversionId',
+    dcfaId: 'dcfaId',
+  },
 ];
 
 const trackCallPayload = {

diff --git a/packages/analytics-js-integrations/__tests__/integrations/GoogleAds/browser.test.js b/packages/analytics-js-integrations/__tests__/integrations/GoogleAds/browser.test.js
@@ -49,6 +49,12 @@ describe('GoogleAds init tests', () => {
     googleAds.init();
     expect(typeof window.gtag).toBe('function');
   });
+
+  test('should call window.gtag with config and dcfaId when dcfaId is truthy', () => {
+    const googleAds = new GoogleAds(googleAdsConfigs[7], {}, destinationInfo);
+    googleAds.init();
+    expect(typeof window.gtag).toBe('function');
+  });
 });
 
 // Old Config Test Cases

diff --git a/packages/analytics-js-integrations/src/integrations/GoogleAds/browser.js b/packages/analytics-js-integrations/src/integrations/GoogleAds/browser.js
@@ -48,6 +48,7 @@ class GoogleAds {
     this.dynamicRemarketing = config.dynamicRemarketing;
     this.allowEnhancedConversions = config.allowEnhancedConversions || false;
     this.v2 = config.v2 || true;
+    this.dcfaId = config.dcfaId || '';
     this.name = NAME;
     ({
       shouldApplyDeviceModeTransformation: this.shouldApplyDeviceModeTransformation,
@@ -77,6 +78,10 @@ class GoogleAds {
     }
 
     window.gtag('config', this.conversionId, config);
+
+    if (this.dcfaId) {
+      window.gtag('config', this.dcfaId);
+    }
   }
 
   isLoaded() {