test: improve code coverage

rudderlabs · Nov 8, 2024 · bd79c67 · bd79c67
1 parent c9be93a
commit bd79c67
Show file tree

Hide file tree

Showing 3 changed files with 84 additions and 77 deletions.
diff --git a/packages/analytics-js-plugins/src/deviceModeDestinations/index.ts b/packages/analytics-js-plugins/src/deviceModeDestinations/index.ts
@@ -73,7 +73,7 @@ const DeviceModeDestinations = (): ExtensionPlugin => ({
       externalSrcLoader: IExternalSrcLoader,
       errorHandler?: IErrorHandler,
       logger?: ILogger,
-      externalScriptOnLoad?: (id?: string) => void,
+      externalScriptOnLoad?: (id?: string, error?: Error) => void,
     ) {
       const integrationsCDNPath = state.lifecycle.integrationsCDNPath.value;
       const activeDestinations = state.nativeDestinations.activeDestinations.value;

diff --git a/packages/analytics-js/__fixtures__/fixtures.ts b/packages/analytics-js/__fixtures__/fixtures.ts
@@ -1,5 +1,6 @@
-import type { SourceConfigResponse } from '@rudderstack/analytics-js/components/configManager/types';
 import { COOKIE_KEYS } from '@rudderstack/analytics-js-cookies/constants/cookies';
+import type { StorageEntries } from '@rudderstack/analytics-js-common/types/ApplicationState';
+import type { SourceConfigResponse } from '@rudderstack/analytics-js-common/types/LoadOptions';
 
 const identifyRequestPayload = {
   userId: '123456',
@@ -42,15 +43,6 @@ const screenRequestPayload = {
   },
 };
 
-const groupRequestPayload = {
-  userId: '12345',
-  groupId: '1',
-  traits: {
-    name: 'Company',
-    description: 'Google',
-  },
-};
-
 const aliasRequestPayload = {
   previousId: 'old_id',
   userId: 'new_id',
@@ -264,7 +256,7 @@ const entriesWithOnlyCookieStorage = {
     type: 'cookieStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithOnlyLocalStorage = {
   userId: {
@@ -303,7 +295,7 @@ const entriesWithOnlyLocalStorage = {
     type: 'localStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithoutCookieStorage = {
   userId: {
@@ -342,7 +334,7 @@ const entriesWithoutCookieStorage = {
     type: 'localStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithoutCookieAndLocalStorage = {
   userId: {
@@ -381,7 +373,7 @@ const entriesWithoutCookieAndLocalStorage = {
     type: 'sessionStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithOnlyNoStorage = {
   userId: {
@@ -420,7 +412,7 @@ const entriesWithOnlyNoStorage = {
     type: 'none',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithOnlySessionStorage = {
   userId: {
@@ -459,7 +451,7 @@ const entriesWithOnlySessionStorage = {
     type: 'sessionStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithMixStorage = {
   userId: {
@@ -498,7 +490,7 @@ const entriesWithMixStorage = {
     type: 'memoryStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithMixStorageButWithoutNone = {
   userId: {
@@ -537,7 +529,7 @@ const entriesWithMixStorageButWithoutNone = {
     type: 'memoryStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const loadOptionWithEntry = {
   userId: {
@@ -606,7 +598,7 @@ const entriesWithInMemoryFallback = {
     type: 'memoryStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const loadOptionWithInvalidEntry = {
   userId: {
@@ -657,7 +649,7 @@ const entriesWithStorageOnlyForSession = {
     type: 'none',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const anonymousIdWithNoStorageEntries = {
   userId: {
@@ -696,7 +688,7 @@ const anonymousIdWithNoStorageEntries = {
     type: 'cookieStorage',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 const entriesWithStorageOnlyForAnonymousId = {
   userId: {
@@ -735,7 +727,7 @@ const entriesWithStorageOnlyForAnonymousId = {
     type: 'none',
     key: COOKIE_KEYS.authToken,
   },
-};
+} as unknown as StorageEntries;
 
 export {
   identifyRequestPayload,