refactor: log warning instead error when a storage capability is unav…

…ailable (#1638)
rudderlabs · Mar 6, 2024 · c9abc60 · c9abc60
1 parent 56eb22a
commit c9abc60
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/packages/analytics-js-plugins/__fixtures__/msw.handlers.js b/packages/analytics-js-plugins/__fixtures__/msw.handlers.js
@@ -40,6 +40,11 @@ const handlers = [
       status: 500,
     });
   }),
+  http.get(`https://asdf.com/bugsnag.min.js`, () => {
+    return new HttpResponse(errorMessage, {
+      status: 404,
+    });
+  }),
 ];
 
 export { handlers };
diff --git a/packages/analytics-js-plugins/__tests__/bugsnag/utils.test.ts b/packages/analytics-js-plugins/__tests__/bugsnag/utils.test.ts
@@ -17,6 +17,7 @@ import {
   onError,
   getAppStateForMetadata,
 } from '../../src/bugsnag/utils';
+import { server } from '../../__fixtures__/msw.server';
 
 describe('Bugsnag utilities', () => {
   describe('isApiKeyValid', () => {
@@ -263,6 +264,13 @@ describe('Bugsnag utilities', () => {
   });
 
   describe('loadBugsnagSDK', () => {
+    beforeAll(() => {
+      server.listen();
+    });
+
+    afterAll(() => {
+      server.close();
+    });
     let insertBeforeSpy: any;
 
     class MockLogger implements ILogger {

diff --git a/packages/analytics-js/src/components/capabilitiesManager/detection/storage.ts b/packages/analytics-js/src/components/capabilitiesManager/detection/storage.ts
@@ -69,7 +69,7 @@ const isStorageAvailable = (
     if (isStorageQuotaExceeded(err)) {
       reason = 'full';
     }
-    logger?.error(`${msgPrefix}${reason}.`, err);
+    logger?.warn(`${msgPrefix}${reason}.`, err);
     return false;
   }
 };