chore: address comments

rudderlabs · Jun 7, 2024 · dae6b42 · dae6b42
1 parent 3946f3f
commit dae6b42
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/analytics-js-integrations/src/utils/commonUtils.js b/packages/analytics-js-integrations/src/utils/commonUtils.js
@@ -2,10 +2,10 @@ import { isDefined, isString } from '@rudderstack/analytics-js-common/utilities/
 import { pick as ramdaPick, pickBy, isEmpty } from 'ramda';
 
 const isNotEmpty = x => {
-  if (typeof x === 'number' || typeof x === 'boolean') {
-    return isEmpty(x); // Numbers and booleans are inherently "not empty"
+  if (typeof x === 'object' || typeof x === 'string') {
+    return !isEmpty(x); // Numbers and booleans are inherently "not empty"
   }
-  return !isEmpty(x);
+  return isEmpty(x);
 };
 const isNotNull = x => x != null;
 const isDefinedAndNotNull = x => isDefined(x) && isNotNull(x);