fix: optimize localstorage key access

packages/analytics-js-common/src/types/Store.ts

@@ -54,6 +54,7 @@ export interface IStore {
 
 export interface IStorage extends Storage {
   configure?(options: StorageOptions): void;
+  keys(): string[];
   isEnabled?: boolean;
 }
 

packages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.ts

@@ -705,45 +705,31 @@ class RetryQueue implements IQueue<QueueItemData> {
     };
     const findOtherQueues = (name: string): IStore[] => {
       const res: IStore[] = [];
-      const storage = this.store.getOriginalEngine();
-
-      for (let i = 0; i < storage.length; i++) {
-        const k = storage.key(i);
-        const parts: string[] = k ? k.split('.') : [];
-
-        if (parts.length !== 3) {
-          // eslint-disable-next-line no-continue
-          continue;
-        }
-
-        if (parts[0] !== name) {
-          // eslint-disable-next-line no-continue
-          continue;
-        }
-
-        if (parts[2] !== QueueStatuses.ACK) {
-          // eslint-disable-next-line no-continue
-          continue;
+      const storageKeys = this.store.getOriginalEngine().keys();
+      storageKeys.forEach((k: string) => {
+        const keyParts: string[] = k ? k.split('.') : [];
+
+        if (
+          keyParts.length >= 3 &&
+          keyParts[0] === name &&
+          keyParts[1] !== this.id &&
+          keyParts[2] === QueueStatuses.ACK
+        ) {
+          res.push(
+            this.storeManager.setStore({
+              id: keyParts[1] as string,
+              name,
+              validKeys: QueueStatuses,
+              type: LOCAL_STORAGE,
+            }),
+          );
         }
-
-        res.push(
-          this.storeManager.setStore({
-            id: parts[1] as string,
-            name,
-            validKeys: QueueStatuses,
-            type: LOCAL_STORAGE,
-          }),
-        );
-      }
+      });
 
       return res;
     };
 
     findOtherQueues(this.name).forEach(store => {
-      if (store.id === this.id) {
-        return;
-      }
-
       if (this.schedule.now() - store.get(QueueStatuses.ACK) < this.timeouts.reclaimTimeout) {
         return;
       }

packages/analytics-js/src/services/StoreManager/storages/CookieStorage.ts

@@ -68,12 +68,14 @@ class CookieStorage implements IStorage {
     // better to explicitly clear specific ones if needed
   }
 
-  // This cannot be implemented for cookies
-  // eslint-disable-next-line class-methods-use-this
   key(index: number): Nullable<string> {
-    const cookies = cookie();
-    const cookieNames = Object.keys(cookies);
-    return isUndefined(cookieNames[index]) ? null : (cookieNames[index] as string);
+    const curKeys = this.keys();
+    return curKeys[index] ?? null;
+  }
+
+  // eslint-disable-next-line class-methods-use-this
+  keys(): string[] {
+    return Object.keys(cookie());
   }
 }
 

packages/analytics-js/src/services/StoreManager/storages/InMemoryStorage.ts

@@ -57,7 +57,12 @@ class InMemoryStorage implements IStorage {
   }
 
   key(index: number): Nullable<string> {
-    return Object.keys(this.data)[index] ? (Object.keys(this.data)[index] as string) : null;
+    const curKeys = this.keys();
+    return curKeys[index] ?? null;
+  }
+
+  keys(): string[] {
+    return Object.keys(this.data);
   }
 }
 

packages/analytics-js/src/services/StoreManager/storages/LocalStorage.ts

@@ -57,9 +57,14 @@ class LocalStorage implements IStorage {
     this.length = 0;
   }
 
-  // eslint-disable-next-line class-methods-use-this
   key(index: number): Nullable<string> {
-    return store.keys()[index] ? (store.keys()[index] as string) : null;
+    const curKeys = this.keys();
+    return curKeys[index] ?? null;
+  }
+
+  // eslint-disable-next-line class-methods-use-this
+  keys(): string[] {
+    return store.keys();
   }
 }
 

packages/analytics-js/src/services/StoreManager/storages/sessionStorage.ts

@@ -6,6 +6,7 @@ import type { ILogger } from '@rudderstack/analytics-js-common/types/Logger';
 import { mergeDeepRight } from '@rudderstack/analytics-js-common/utilities/object';
 import { isUndefined } from '@rudderstack/analytics-js-common/utilities/checks';
 import { SESSION_STORAGE } from '@rudderstack/analytics-js-common/constants/storages';
+import type { Nullable } from '@rudderstack/analytics-js-common/types/Nullable';
 import { isStorageAvailable } from '../../../components/capabilitiesManager/detection';
 import { defaultLogger } from '../../Logger';
 import { getDefaultSessionStorageOptions } from './defaultOptions';
@@ -54,9 +55,20 @@ class SessionStorage implements IStorage {
     this.length = 0;
   }
 
-  key(index: number): string | null {
+  key(index: number): Nullable<string> {
     return this.store.key(index);
   }
+
+  keys(): string[] {
+    const keys: string[] = [];
+    for (let i = 0; i < this.store.length; i += 1) {
+      const key = this.store.key(i);
+      if (key !== null) {
+        keys.push(key);
+      }
+    }
+    return keys;
+  }
 }
 
 const defaultSessionStorage = new SessionStorage({}, defaultLogger);