Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node version to 20 #1405

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.17.1
20.7.0
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ describe('KetchConsentManager - Utils', () => {
expect(ketchConsentData).toBeUndefined();
expect(mockLogger.error).toHaveBeenCalledWith(
'KetchConsentManagerPlugin:: Failed to parse the consent cookie.',
new SyntaxError('Unexpected token i in JSON at position 0'),
new SyntaxError('Unexpected token \'i\', "i�" is not valid JSON'),
);
});

Expand All @@ -165,7 +165,7 @@ describe('KetchConsentManager - Utils', () => {
expect(ketchConsentData).toBeUndefined();
expect(mockLogger.error).toHaveBeenCalledWith(
'KetchConsentManagerPlugin:: Failed to parse the consent cookie.',
new SyntaxError('Unexpected token a in JSON at position 0'),
new SyntaxError('Unexpected token \'a\', "abcde" is not valid JSON'),
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ describe('Plugin - Storage Migrator', () => {
);
expect(migratedVal).toBe(null);
expect(mockErrorHandler.onError).toHaveBeenCalledWith(
new SyntaxError('Unexpected token h in JSON at position 0'),
new SyntaxError('Unexpected token \'h\', "hello" is not valid JSON'),
'StorageMigratorPlugin',
'Failed to retrieve or parse data for someKey from storage.',
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ describe('HttpClient', () => {
expect(response).toBeUndefined();
expect(defaultErrorHandler.onError).toHaveBeenCalledTimes(1);
expect(defaultErrorHandler.onError).toHaveBeenCalledWith(
new Error('Failed to parse response data: Unexpected token r in JSON at position 1'),
new Error(
"Failed to parse response data: Expected property name or '}' in JSON at position 1",
),
'HttpClient',
);
done();
Expand Down