feat: error reporting plugin

packages/analytics-js-plugins/__tests__/errorReporting/utils.test.ts

@@ -313,7 +313,7 @@ describe('Error Reporting utilities', () => {
       console.log(JSON.stringify(enhancedError));
       const expectedOutcome = {
         notifier: {
-          name: 'Rudderstack JavaScript SDK Error Notifier',
+          name: 'RudderStack JavaScript SDK Error Notifier',
           version: '__PACKAGE_VERSION__',
           url: 'https://github.com/rudderlabs/rudder-sdk-js',
         },

packages/analytics-js-plugins/src/errorReporting/constants.ts

@@ -19,7 +19,7 @@ const APP_STATE_EXCLUDE_KEYS = [
   'traits',
 ];
 const REQUEST_TIMEOUT_MS = 10 * 1000; // 10 seconds
-const NOTIFIER_NAME = 'Rudderstack JavaScript SDK Error Notifier';
+const NOTIFIER_NAME = 'RudderStack JavaScript SDK Error Notifier';
 const SDK_GITHUB_URL = 'https://github.com/rudderlabs/rudder-sdk-js';
 const SOURCE_NAME = 'js';
 

packages/analytics-js-plugins/src/errorReporting/index.ts

@@ -10,6 +10,7 @@
 import type { ErrorState, SDKError } from '@rudderstack/analytics-js-common/types/ErrorHandler';
 import { Event } from '@bugsnag/core';
 import type { IHttpClient } from '@rudderstack/analytics-js-common/types/HttpClient';
+import { clone } from 'ramda';
 import {
   createNewBreadCrumb,
   getConfigForPayloadCreation,
@@ -51,12 +52,12 @@
 
       // filter errors
       if (!isRudderSDKError(errorPayload.errors[0])) {
         return;
       }
 
       // attach breadcrumbs
       if (state.reporting.breadCrumbs.value.length > 0) {
-        errorPayload.breadcrumbs = state.reporting.breadCrumbs.value;
+        errorPayload.breadcrumbs = clone(state.reporting.breadCrumbs.value);
       }
 
       // enrich error payload
@@ -80,7 +81,7 @@
     },
     breadcrumb: (message: string, state: ApplicationState, metaData?: BreadCrumbMetaData): void => {
       if (!message) {
         return;
       }
       state.reporting.breadCrumbs.value = [
         ...state.reporting.breadCrumbs.value,

packages/analytics-js/__tests__/services/ErrorHandler/ErrorHandler.test.ts

@@ -1,9 +1,9 @@
-import { SDKError } from '@rudderstack/analytics-js-common/types/ErrorHandler';
+import type { SDKError } from '@rudderstack/analytics-js-common/types/ErrorHandler';
 import { defaultHttpClient } from '../../../src/services/HttpClient';
 import { defaultLogger } from '../../../src/services/Logger';
 import { defaultPluginEngine } from '../../../src/services/PluginEngine';
 import { ErrorHandler } from '../../../src/services/ErrorHandler';
-import { state } from '../../../src/state';
+import { state, resetState } from '../../../src/state';
 
 jest.mock('../../../src/services/Logger', () => {
   const originalModule = jest.requireActual('../../../src/services/Logger');
@@ -43,6 +43,7 @@ describe('ErrorHandler', () => {
   let errorHandlerInstance: ErrorHandler;
 
   beforeEach(() => {
+    resetState();
     errorHandlerInstance = new ErrorHandler(defaultLogger, defaultPluginEngine, defaultHttpClient);
   });
 
@@ -78,6 +79,8 @@ describe('ErrorHandler', () => {
   });
 
   it('should log error for Errors with context and custom message if logger exists', () => {
+    state.reporting.isErrorReportingEnabled.value = true;
+    state.reporting.isErrorReportingPluginLoaded.value = true;
     errorHandlerInstance.onError(new Error('dummy error'), 'Unit test', 'dummy  custom  message');
 
     expect(defaultPluginEngine.invokeSingle).toHaveBeenCalledTimes(1);
@@ -101,6 +104,8 @@ describe('ErrorHandler', () => {
   });
 
   it('should log error for messages with context and custom message if logger exists', () => {
+    state.reporting.isErrorReportingEnabled.value = true;
+    state.reporting.isErrorReportingPluginLoaded.value = true;
     errorHandlerInstance.onError('dummy error', 'Unit test', 'dummy custom message');
 
     expect(defaultPluginEngine.invokeSingle).toHaveBeenCalledTimes(1);
@@ -125,6 +130,8 @@ describe('ErrorHandler', () => {
 
   it('should log and throw for messages with context and custom message if logger exists and shouldAlwaysThrow', () => {
     try {
+      state.reporting.isErrorReportingEnabled.value = true;
+      state.reporting.isErrorReportingPluginLoaded.value = true;
       errorHandlerInstance.onError('dummy error', 'Unit test', 'dummy custom message', true);
     } catch (err) {
       expect(defaultPluginEngine.invokeSingle).toHaveBeenCalledTimes(1);

packages/analytics-js/src/services/ErrorHandler/ErrorHandler.ts

@@ -44,7 +44,7 @@
 
         if (errorToProcess) {
           // send it to the plugin
           this.notifyError(errorToProcess.error, errorToProcess.errorState);
         }
       }
     }
@@ -101,20 +101,22 @@
       });
     }
 
-    if (
-      state.reporting.isErrorReportingEnabled.value &&
-      !state.reporting.isErrorReportingPluginLoaded.value
-    ) {
-      // buffer the error
-      this.errorBuffer.enqueue({ error, errorState });
-    } else {
-      // send it to plugin
-      // eslint-disable-next-line no-lonely-if
-      if (errorType === 'handledException') {
-        this.notifyError(normalizedError, errorState);
-      } else {
-        this.notifyError(error, errorState);
+    const isErrorReportingEnabled = state.reporting.isErrorReportingEnabled.value;
+    const isErrorReportingPluginLoaded = state.reporting.isErrorReportingPluginLoaded.value;
+    try {
+      if (isErrorReportingEnabled) {
+        if (!isErrorReportingPluginLoaded) {
+          // buffer the error
+          this.errorBuffer.enqueue({
+            error: errorType === 'handledException' ? normalizedError : error,
+            errorState,
+          });
+        } else {
+          this.notifyError(errorType === 'handledException' ? normalizedError : error, errorState);
+        }
       }
+    } catch (e) {
+      this.logger?.error(NOTIFY_FAILURE_ERROR(ERROR_HANDLER), e);
     }
 
     if (errorType === 'handledException') {

packages/analytics-js/src/services/ErrorHandler/processError.ts

@@ -55,6 +55,9 @@
   if ((error instanceof Error || error instanceof ErrorEvent) && error.message) {
     return !ERROR_MESSAGES_TO_BE_FILTERED.some(e => error.message.includes(e));
   }
+  if (error instanceof PromiseRejectionEvent && error.reason) {
+    return !ERROR_MESSAGES_TO_BE_FILTERED.some(e => error.reason.includes(e));
+  }
   return true;
 };