-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics-js-loading-scripts): add version in polyfill io url #1630
fix(analytics-js-loading-scripts): add version in polyfill io url #1630
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1630 +/- ##
========================================
Coverage 52.35% 52.35%
========================================
Files 586 586
Lines 16653 16653
Branches 3241 3250 +9
========================================
Hits 8719 8719
+ Misses 6485 6458 -27
- Partials 1449 1476 +27 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
Quality Gate passedIssues Measures |
PR Description
POlyfill io url returns empty file if version is not defined in the query params. It might be a glitch on their side or a breaking change they introduced.
To rectify IE11 loading, changed the loading snippet accordingly
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security