feat: add dcfaid support, add test #1640
Conversation
WalkthroughThe recent updates introduce a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- packages/analytics-js-integrations/tests/integrations/GoogleAds/fixtures/data.js (1 hunks)
- packages/analytics-js-integrations/tests/integrations/GoogleAds/browser.test.js (1 hunks)
- packages/analytics-js-integrations/src/integrations/GoogleAds/browser.js (2 hunks)
Additional comments: 4
packages/analytics-js-integrations/src/integrations/GoogleAds/browser.js (2)
- 51-51: The addition of
dcfaIdwith a default empty string value is consistent with the handling of optional configuration properties in the class. This ensures thatdcfaIdcan be safely used throughout the class without additional null checks.- 82-84: The conditional handling of
dcfaIdin theinitmethod is correctly implemented, ensuring that thegtagconfiguration call is made only whendcfaIdis provided. It's important to verify that thegtagfunction behaves as expected when called with a single ID parameter, as this differs from the typical use case with both an ID and a configuration object.packages/analytics-js-integrations/__tests__/integrations/GoogleAds/__fixtures__/data.js (1)
- 211-214: The addition of a new configuration object with
conversionIdanddcfaIdproperties in thegoogleAdsConfigsarray is appropriate for testing the newly introduceddcfaIdfunctionality. This ensures comprehensive test coverage for scenarios involvingdcfaId.packages/analytics-js-integrations/__tests__/integrations/GoogleAds/browser.test.js (1)
- 53-57: The addition of a test case to verify the behavior of
window.gtagwhendcfaIdis truthy is well-implemented. It effectively ensures that the integration correctly handles thedcfaIdproperty, contributing to comprehensive test coverage for the new functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1640 +/- ##
========================================
Coverage 53.89% 53.90%
========================================
Files 461 461
Lines 15588 15591 +3
Branches 3094 3097 +3
========================================
+ Hits 8401 8404 +3
Misses 5871 5871
Partials 1316 1316 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
yashasvibajpai
requested review from
ItsSudip,
shrouti1507,
sandeepdsvs,
koladilip and
mihir-4116
as code owners
|
|
Hello! This PR has been open for 20 days without any activity. Therefore, it's considered as stale and is scheduled to be closed in 10 days. If you're still working on this, please remove the 'Stale' label or add a comment to keep it open. Thanks for your contribution! |
|
Hello! This PR has been open for 20 days without any activity. Therefore, it's considered as stale and is scheduled to be closed in 10 days. If you're still working on this, please remove the 'Stale' label or add a comment to keep it open. Thanks for your contribution! |
|
Hello! This PR has been open for 20 days without any activity. Therefore, it's considered as stale and is scheduled to be closed in 10 days. If you're still working on this, please remove the 'Stale' label or add a comment to keep it open. Thanks for your contribution! |
|
Hello! This PR has been open for 20 days without any activity. Therefore, it's considered as stale and is scheduled to be closed in 10 days. If you're still working on this, please remove the 'Stale' label or add a comment to keep it open. Thanks for your contribution! |
PR Description
Please include a summary of the change along with the relevant motivation and context.
Linear task (optional)
Resolves INT-1747
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
dcfaIdto improve tracking capabilities.dcfaIdis provided in Google Ads configurations.