chore: remove duplicate config named eventWhiteList #1652
Conversation
ItsSudip
requested review from
shrouti1507,
sandeepdsvs,
koladilip and
mihir-4116
as code owners
WalkthroughThe update involves a significant change in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/analytics-js-integrations/src/integrations/TVSquared/browser.js (2 hunks)
Additional comments: 1
packages/analytics-js-integrations/src/integrations/TVSquared/browser.js (1)
- 60-65: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [58-76]
The
trackmethod has been updated to remove the event whitelisting logic. This change aligns with the PR's objective to eliminate redundancy by removing theeventWhiteListconfiguration. It's important to ensure that this change does not inadvertently affect the tracking of events that should be filtered or handled differently. Consider adding tests or documentation to clarify how events are now expected to be handled without the whitelist logic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1652 +/- ##
===========================================
+ Coverage 54.12% 54.14% +0.01%
===========================================
Files 462 462
Lines 15654 15648 -6
Branches 3107 3104 -3
===========================================
- Hits 8473 8472 -1
- Misses 5860 5877 +17
+ Partials 1321 1299 -22 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
packages/analytics-js-integrations/src/integrations/TVSquared/browser.js
Show resolved
Hide resolved
|
PR Description
Resolves INT-672
We are removing the duplicate config named eventWhiteList which is the same as the default SDK config named allowlist.
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
TVSquaredintegration, allowing all events to be processed without filtering.