chore(release): pulling release/3.1.0 into main #1656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test (#1654) * chore: default constant for plugins and integrations base url updated * chore: updated beta path in unit test
* feat: remove beta status for all the packages * fix: mono repo version bump * chore: remove beta status from package version * chore: use user group for code owners * chore: use github runner for publishing new releases * chore: fix inconsistencies in github workflows * fix: dependency chain across all the packages and typos * fix: reset the crypto-es version * fix: crypto-js, crypto-es and vulnerable versions * chore: upgrade size-limit action to the latest version
devops-github-rudderstack
requested review from
sandeepdsvs,
koladilip,
mihir-4116,
saikumarrs and
MoumitaM
as code owners
WalkthroughThe changes largely focus on standardizing terminology, updating dependencies, and refining automation workflows. Key updates include the shift from beta to production versions in URLs and dependencies, the correction of "Javascript" to "JavaScript" across documentation, and the streamlining of GitHub Actions workflows. These modifications enhance consistency, improve deployment processes, and ensure the use of the latest software components. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
=======================================
Coverage 53.89% 53.89%
=======================================
Files 461 461
Lines 15588 15588
Branches 3097 3087 -10
=======================================
Hits 8401 8401
- Misses 5881 5919 +38
+ Partials 1306 1268 -38 ☔ View full report in Codecov by Sentry. |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (18)
migrations.jsonis excluded by:!**/*.jsonpackage-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/package.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/project.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.jsonpackages/sanity-suite/project.jsonis excluded by:!**/*.json
Files selected for processing (29)
- .github/workflows/deploy-npm.yml (2 hunks)
- .github/workflows/deploy-prod.yml (6 hunks)
- .github/workflows/deploy-staging.yml (1 hunks)
- .github/workflows/publish-new-release.yml (1 hunks)
- .github/workflows/security-code-quality-and-bundle-size-checks.yml (1 hunks)
- CODEOWNERS (1 hunks)
- packages/analytics-js-common/CHANGELOG.md (1 hunks)
- packages/analytics-js-common/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-common/README.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-integrations/README.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/README.md (1 hunks)
- packages/analytics-js-service-worker/README.md (1 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js/README.md (1 hunks)
- packages/analytics-js/tests/components/configManager/cdnPaths.test.ts (1 hunks)
- packages/analytics-js/src/constants/urls.ts (1 hunks)
- packages/analytics-v1.1/CHANGELOG.md (1 hunks)
- packages/analytics-v1.1/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/README.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- packages/sanity-suite/README.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (13)
- packages/analytics-js-integrations/CHANGELOG.md
- packages/analytics-js-integrations/README.md
- packages/analytics-js-plugins/CHANGELOG.md
- packages/analytics-js-plugins/CHANGELOG_LATEST.md
- packages/analytics-js-plugins/README.md
- packages/analytics-js-service-worker/README.md
- packages/analytics-js/CHANGELOG_LATEST.md
- packages/analytics-v1.1/CHANGELOG.md
- packages/analytics-v1.1/CHANGELOG_LATEST.md
- packages/loading-scripts/CHANGELOG.md
- packages/sanity-suite/CHANGELOG.md
- packages/sanity-suite/README.md
- sonar-project.properties
Additional comments: 22
CODEOWNERS (1)
- 1-1: The transition to a team-based approach for code ownership (
@rudderlabs/js-sdk) is a positive change, promoting scalability and maintainability of the project. This approach ensures shared responsibility and potentially improves response times for PR reviews and issue resolutions.packages/analytics-js-common/CHANGELOG_LATEST.md (1)
- 1-1: The version update from
3.0.0-beta.19to0.0.1is significant, indicating a major overhaul or rebranding. It's crucial to ensure clear communication to users about the nature and implications of these changes, as resetting the version number after a beta release could potentially cause confusion.packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
- 1-5: Updating the version to
0.0.1and the dependency@rudderstack/analytics-js-commonto version0.0.1are significant changes. It's important to ensure thorough testing of these updates to maintain compatibility and stability across the ecosystem.packages/loading-scripts/CHANGELOG_LATEST.md (1)
- 1-5: The version change to
0.0.1and the update to@rudderstack/analytics-jsversion0.0.1are significant. Clear communication about these changes and thorough testing of the updates are essential to ensure a smooth transition for users.packages/analytics-js/src/constants/urls.ts (1)
- 7-8: Updating URLs from beta to production versions is a positive step towards stabilizing the project. Ensure the correctness of these URLs and verify that any necessary redirects are in place to avoid breaking existing implementations.
.github/workflows/security-code-quality-and-bundle-size-checks.yml (1)
- 26-26: Updating the
github-action-check-size-limittov2.10.0is a good practice to benefit from new features or bug fixes. Ensure compatibility with the existing workflow and verify that no breaking changes are introduced.packages/analytics-js-common/README.md (1)
- 24-24: Correcting the capitalization of "JavaScript" in the documentation is a minor but important detail that enhances professionalism and accuracy. Good attention to detail.
packages/analytics-js/__tests__/components/configManager/cdnPaths.test.ts (1)
- 64-64: The test case for verifying the default path with versioned folder when no script src exists and integrations version is locked correctly uses the
dummyVersionvariable. This approach ensures that the test remains valid even if the version changes, avoiding the need to update the hardcoded version in the test. This change aligns with best practices for maintainability and flexibility in test cases..github/workflows/publish-new-release.yml (1)
- 16-16: Changing the
runs-onconfiguration toubuntu-latestfor thereleasejob is a positive move towards standardization and reliability. Using GitHub-hosted runners can provide a more consistent environment for deployments and reduce the maintenance overhead associated with self-hosted runners. Ensure that any dependencies or environment specifics tied to the self-hosted runner are compatible withubuntu-latest..github/workflows/deploy-staging.yml (3)
- 72-72: Renaming the task to "Sync files to S3 staging directory" improves clarity and accurately describes the action being performed. This change enhances the readability of the workflow file and makes it easier for new contributors to understand the purpose of each step.
- 80-80: Updating the task name to "Create Cloudfront invalidation" clearly communicates the action being taken. This naming convention is straightforward and aligns with best practices for naming tasks in a way that immediately conveys their purpose.
- 85-85: The task name "Sync files to S3 v1.1 staging directory" is well-chosen, providing clear insight into the specific action and target directory. This level of detail in task naming facilitates easier maintenance and understanding of the workflow.
.github/workflows/deploy-npm.yml (2)
- 21-21: Switching to
ubuntu-latestfor theruns-ondirective aligns with best practices for using GitHub hosted runners, especially for critical operations like publishing to NPM. This ensures a stable and consistent environment for the deployment process. It's important to verify that all dependencies and scripts are compatible with theubuntu-latestenvironment.- 75-75: Modifying the step name to "Send message to Slack channel" provides a clear and concise description of the action being performed. This change enhances the readability of the workflow and makes it easier for contributors to navigate and understand the purpose of each step.
packages/analytics-js-common/CHANGELOG.md (1)
- 5-5: The introduction of version
0.0.1marks a significant change from the previous beta versioning scheme. Please ensure that the version jump from3.0.0-beta.19to0.0.1is clearly communicated in the release notes or documentation to avoid confusion among users..github/workflows/deploy-prod.yml (6)
- 98-98: Renaming the step from "Sync files to S3 v3 folder" to "Sync files to S3" improves clarity by removing the version number, which might not be necessary for understanding the step's purpose. This change aligns with best practices for naming by keeping it simple and focused on the action being performed.
- 110-110: The renaming of "Sync files to S3 v3 versioned folder" to "Sync files to S3 versioned directory" not only corrects the terminology (from "folder" to "directory") but also removes the specific version number, making the step name more generic and potentially applicable to future versions without needing further changes.
- 122-122: Updating the comment to mention the '/latest' directory instead of '/latest' folder is a minor but meaningful change that aligns with the more commonly used terminology in the context of directories and paths in development and deployment scripts. It's good to see attention to detail in comments as well, as they guide future maintainers.
- 137-137: Renaming the step "Send message to Slack channel v3" to "Send message to Slack channel" simplifies the step name by removing the version number. This change is consistent with the approach taken in other step renamings and helps in maintaining a cleaner and more understandable workflow file.
- 172-172: The renaming of "Sync files to S3 v1.1 folder" to "Sync files to S3 v1.1 directory" corrects the terminology and makes the step name more precise. It's important to use consistent terminology across the workflow file, and this change contributes to that consistency.
- 187-187: Renaming "Sync files to S3 v1.1 versioned folder" to "Sync files to S3 v1.1 versioned directory" is another instance of improving terminology consistency within the workflow file. This change, along with the others, helps in making the workflow steps clearer and more standardized.
packages/analytics-js/CHANGELOG.md (1)
- 5-10: The changelog update correctly documents the dependency updates for
@rudderstack/analytics-js-commonand@rudderstack/analytics-js-pluginsto version0.0.1. Ensure that the version numbers are accurate and that the provided links lead to the correct comparison pages on GitHub.
size-limit report 📦
|
|
Invalid PR. Hence, closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR
Summary by CodeRabbit
0.0.1across multiple packages with dependency updates and a link to the comparison between versions foranalytics-js-common.CODEOWNERSfile with new ownership information.sonar.projectVersionto reflect the new beta version.cdnPaths.test.ts.