chore(release): pulling release/3.1.0 into main #1657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test (#1654) * chore: default constant for plugins and integrations base url updated * chore: updated beta path in unit test
* feat: remove beta status for all the packages * fix: mono repo version bump * chore: remove beta status from package version * chore: use user group for code owners * chore: use github runner for publishing new releases * chore: fix inconsistencies in github workflows * fix: dependency chain across all the packages and typos * fix: reset the crypto-es version * fix: crypto-js, crypto-es and vulnerable versions * chore: upgrade size-limit action to the latest version
devops-github-rudderstack
requested review from
shrouti1507,
sandeepdsvs,
koladilip,
mihir-4116,
saikumarrs and
MoumitaM
as code owners
WalkthroughThe recent updates primarily focus on renaming steps in GitHub workflows for clarity, updating dependencies across various packages, and correcting the capitalization of "JavaScript" in documentation. A significant version change is noted in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Invalid PR. Hence, closing it. |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (18)
migrations.jsonis excluded by:!**/*.jsonpackage-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/package.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/project.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.jsonpackages/sanity-suite/project.jsonis excluded by:!**/*.json
Files selected for processing (29)
- .github/workflows/deploy-npm.yml (2 hunks)
- .github/workflows/deploy-prod.yml (6 hunks)
- .github/workflows/deploy-staging.yml (1 hunks)
- .github/workflows/publish-new-release.yml (1 hunks)
- .github/workflows/security-code-quality-and-bundle-size-checks.yml (1 hunks)
- CODEOWNERS (1 hunks)
- packages/analytics-js-common/CHANGELOG.md (1 hunks)
- packages/analytics-js-common/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-common/README.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-integrations/README.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/README.md (1 hunks)
- packages/analytics-js-service-worker/README.md (1 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js/README.md (1 hunks)
- packages/analytics-js/tests/components/configManager/cdnPaths.test.ts (1 hunks)
- packages/analytics-js/src/constants/urls.ts (1 hunks)
- packages/analytics-v1.1/CHANGELOG.md (1 hunks)
- packages/analytics-v1.1/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/README.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- packages/sanity-suite/README.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (16)
- packages/analytics-js-common/README.md
- packages/analytics-js-integrations/CHANGELOG.md
- packages/analytics-js-integrations/README.md
- packages/analytics-js-plugins/CHANGELOG.md
- packages/analytics-js-plugins/CHANGELOG_LATEST.md
- packages/analytics-js-plugins/README.md
- packages/analytics-js-service-worker/README.md
- packages/analytics-js/CHANGELOG.md
- packages/analytics-js/README.md
- packages/analytics-v1.1/CHANGELOG.md
- packages/analytics-v1.1/CHANGELOG_LATEST.md
- packages/loading-scripts/CHANGELOG.md
- packages/loading-scripts/README.md
- packages/sanity-suite/CHANGELOG.md
- packages/sanity-suite/README.md
- sonar-project.properties
Additional comments: 22
CODEOWNERS (1)
- 1-1: The update to the
CODEOWNERSfile, assigning@rudderlabs/js-sdkas the owner for the/packages/analytics-js-integrations/directory, is clear and makes sense for organizational purposes. Ensure that all relevant parties are aware of this change.packages/analytics-js-common/CHANGELOG_LATEST.md (1)
- 1-1: The version update in
CHANGELOG_LATEST.mdfrom3.0.0-beta.19to0.0.1is noted. Please confirm that this version change aligns with the intended versioning strategy for the project.packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
- 1-5: The version update to
0.0.1and the dependency update for@rudderstack/analytics-js-commonto version0.0.1inCHANGELOG_LATEST.mdare consistent with project-wide updates. Please ensure that these dependency updates are correctly reflected in thepackage.jsonfiles.packages/loading-scripts/CHANGELOG_LATEST.md (1)
- 1-5: The version update to
0.0.1and the dependency update for@rudderstack/analytics-jsto version0.0.1inCHANGELOG_LATEST.mdare part of the project-wide updates. Please ensure that these dependency updates are correctly reflected in thepackage.jsonfiles.packages/analytics-js/CHANGELOG_LATEST.md (1)
- 1-6: The version update to
0.0.1and the dependency updates for@rudderstack/analytics-js-commonand@rudderstack/analytics-js-pluginsto version0.0.1inCHANGELOG_LATEST.mdare consistent with the project-wide updates. Please ensure that these dependency updates are correctly reflected in thepackage.jsonfiles and check for any compatibility issues.packages/analytics-js/src/constants/urls.ts (1)
- 7-8: The update to use production URLs instead of beta versions in
urls.tsis a significant step towards ensuring stability. Please ensure thorough testing is conducted to verify that the SDK functions as expected with these new URLs..github/workflows/security-code-quality-and-bundle-size-checks.yml (1)
- 26-26: Updating the
github-action-check-size-limitaction tov2.10.0in the workflow is a good practice. Please ensure that this new version is fully compatible with the existing workflow and does not introduce any issues.packages/analytics-js/__tests__/components/configManager/cdnPaths.test.ts (1)
- 64-64: The update to use the
dummyVersionvariable directly incdnPaths.test.ts, instead of a hardcoded beta version, is a good improvement for test maintainability. Please ensure that all tests pass with this new configuration..github/workflows/publish-new-release.yml (1)
- 16-16: Switching to
ubuntu-latestsimplifies runner management. Ensure all dependencies and tools required by the workflow are available in theubuntu-latestenvironment..github/workflows/deploy-staging.yml (3)
- 72-72: Renaming steps for syncing files to S3 improves clarity and maintainability. Good practice.
- 80-80: Updating the Cloudfront invalidation step name enhances clarity. Consistent with best practices.
- 85-85: Adjusting step names for syncing files to the S3 v1.1 staging directory is a positive change for readability.
.github/workflows/deploy-npm.yml (2)
- 21-21: Switching to
ubuntu-latestfor NPM deployment simplifies runner management. Ensure compatibility with theubuntu-latestenvironment.- 75-75: Modifying the step name for sending a message to the Slack channel improves clarity. Good practice.
packages/analytics-js-common/CHANGELOG.md (2)
- 5-5: The introduction of version
0.0.1marks a significant reset or change in the versioning strategy. Ensure that this versioning change is intentional and communicated clearly to users, as it might cause confusion given the previous versioning scheme (3.0.0-beta.19).- 2-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [6-172]
Ensure that all relevant changes, features, and bug fixes introduced in version
0.0.1are documented in the changelog. Given the significant version reset, it's crucial to provide users with comprehensive information about what has changed..github/workflows/deploy-prod.yml (6)
- 98-98: The step renaming from "Sync files to S3 v3 folder" to "Sync files to S3" simplifies the naming and removes the version-specific reference, which could make the workflow more maintainable in the long run.
- 110-110: Renaming "Sync files to S3 v3 versioned folder" to "Sync files to S3 versioned directory" improves consistency in terminology (using "directory" instead of "folder"). This change aligns with common terminology in documentation and code comments.
- 122-122: The comment update from "unused '/latest' folder" to "unused '/latest' directory" maintains consistency in terminology across the workflow file. It's a minor change but contributes to overall readability and clarity.
- 137-137: Renaming the step for sending messages to the Slack channel removes the version-specific reference ("v3"), which could be beneficial for future workflow adjustments. This change might also simplify the process of updating the workflow for subsequent releases.
- 172-172: The step renaming from "Sync files to S3 v1.1 folder" to "Sync files to S3 v1.1 directory" is consistent with the changes made for the v3 steps, improving overall consistency in the workflow file.
- 187-187: Renaming "Sync files to S3 v1.1 versioned folder" to "Sync files to S3 v1.1 versioned directory" aligns with the terminology adjustments made in other parts of the workflow. This consistency in terminology is crucial for maintainability and readability.
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR
Summary by CodeRabbit
New Features
0.0.1for theanalytics-js-commonpackage with significant updates.Documentation
Chores
Refactor
Bug Fixes