chore(release): pulling release/3.1.0 into main #1658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test (#1654) * chore: default constant for plugins and integrations base url updated * chore: updated beta path in unit test
* feat: remove beta status for all the packages * fix: mono repo version bump * chore: remove beta status from package version * chore: use user group for code owners * chore: use github runner for publishing new releases * chore: fix inconsistencies in github workflows * fix: dependency chain across all the packages and typos * fix: reset the crypto-es version * fix: crypto-js, crypto-es and vulnerable versions * chore: upgrade size-limit action to the latest version
devops-github-rudderstack
requested review from
shrouti1507,
sandeepdsvs,
koladilip,
mihir-4116,
saikumarrs and
MoumitaM
as code owners
WalkthroughThe recent updates focus on enhancing workflow efficiency and clarity across GitHub actions, with improvements in naming conventions for better understanding. Changes also include the upgrade of actions and the correction of JavaScript capitalization in various README.md files, reflecting attention to detail and consistency. Additionally, there's an update in test assertions and URL constants to align with current standards, alongside a notable adjustment in code ownership and project versioning to streamline development processes. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Invalid PR. Hence, closing it. |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (17)
migrations.jsonis excluded by:!**/*.jsonpackage-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.jsonpackages/sanity-suite/project.jsonis excluded by:!**/*.json
Files selected for processing (16)
- .github/workflows/deploy-npm.yml (2 hunks)
- .github/workflows/deploy-prod.yml (6 hunks)
- .github/workflows/deploy-staging.yml (1 hunks)
- .github/workflows/publish-new-release.yml (1 hunks)
- .github/workflows/security-code-quality-and-bundle-size-checks.yml (1 hunks)
- CODEOWNERS (1 hunks)
- packages/analytics-js-common/README.md (1 hunks)
- packages/analytics-js-integrations/README.md (1 hunks)
- packages/analytics-js-plugins/README.md (1 hunks)
- packages/analytics-js-service-worker/README.md (1 hunks)
- packages/analytics-js/README.md (1 hunks)
- packages/analytics-js/tests/components/configManager/cdnPaths.test.ts (1 hunks)
- packages/analytics-js/src/constants/urls.ts (1 hunks)
- packages/loading-scripts/README.md (1 hunks)
- packages/sanity-suite/README.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (1)
- sonar-project.properties
Additional comments: 22
CODEOWNERS (1)
- 1-1: The update from individual owners to a team handle (
@rudderlabs/js-sdk) for the specified directory is a good practice for managing permissions and responsibilities more efficiently.packages/analytics-js/src/constants/urls.ts (1)
- 7-8: Removing beta references in URLs and using production URLs directly is a positive step towards ensuring the stability and reliability of the SDK.
packages/loading-scripts/README.md (1)
- 24-24: Correcting the capitalization of "JavaScript" in the description ensures consistency and accuracy in the documentation.
packages/analytics-js-integrations/README.md (1)
- 24-24: Correcting the capitalization of "JavaScript" in the description ensures consistency and accuracy in the documentation.
packages/sanity-suite/README.md (1)
- 24-24: Correcting the capitalization of "JavaScript" in the description ensures consistency and accuracy in the documentation.
.github/workflows/security-code-quality-and-bundle-size-checks.yml (1)
- 26-26: Updating the
github-action-check-size-limitaction to versionv2.10.0is a good practice for incorporating new features or bug fixes.packages/analytics-js-common/README.md (1)
- 24-24: Correcting the capitalization of "JavaScript" in the description ensures consistency and accuracy in the documentation.
packages/analytics-js-plugins/README.md (1)
- 24-24: Correcting the capitalization of "JavaScript" in the description ensures consistency and accuracy in the documentation.
packages/analytics-js/__tests__/components/configManager/cdnPaths.test.ts (1)
- 64-64: The modification to use the
dummyVersionvariable directly in the expected CDN path assertion is a good practice, enhancing test maintainability by avoiding hardcoded values.packages/analytics-js-service-worker/README.md (1)
- 24-24: Correcting the capitalization of "Javascript" to "JavaScript" improves the documentation's consistency and professionalism.
packages/analytics-js/README.md (1)
- 24-24: Correcting the capitalization of "Javascript" to "JavaScript" in the SDK description enhances the documentation's consistency and professionalism.
.github/workflows/publish-new-release.yml (1)
- 16-16: Changing the runner configuration to
ubuntu-latestis a good practice, ensuring the workflow benefits from the latest updates and security patches..github/workflows/deploy-staging.yml (3)
- 72-72: Renaming the step for syncing files to S3 staging directories improves workflow readability and maintainability.
- 80-80: Updating the Cloudfront invalidation step to remove version-specific references is a good practice, enhancing maintainability.
- 85-85: Renaming the step for syncing files to S3 v1.1 staging directory for clarity is beneficial.
.github/workflows/deploy-npm.yml (2)
- 21-21: Restricting the use of GitHub hosted runners for publishing the NPM package with provenance is a good security practice.
- 75-75: Adjusting the Slack message naming for clarity in notifications is beneficial.
.github/workflows/deploy-prod.yml (5)
- 98-98: The step name "Sync files to S3" has been simplified from "Sync files to S3 v3 folder" to enhance clarity. This change aligns with the PR's objective of refining deployment processes.
- 110-110: Renaming "Sync files to S3 v3 versioned folder" to "Sync files to S3 versioned directory" improves consistency in terminology by using "directory" instead of "folder." Good attention to detail.
- 137-137: The step "Send message to Slack channel" has been renamed for simplicity. This change, along with the updated payload structure, should improve the clarity of Slack notifications regarding new releases.
- 172-172: Renaming "Sync files to S3 v1.1 folder" to "Sync files to S3 v1.1 directory" is consistent with the changes made earlier in the file. It's good to see uniformity in naming conventions across the workflow.
- 187-187: The renaming of "Sync files to S3 v1.1 versioned folder" to "Sync files to S3 v1.1 versioned directory" maintains consistency in the use of the term "directory." This change is in line with best practices for clear and consistent naming.
| @@ -119,7 +119,7 @@ jobs: | |||
| run: | | |||
| AWS_MAX_ATTEMPTS=10 aws cloudfront create-invalidation --distribution-id ${{ secrets.AWS_PROD_CF_DISTRIBUTION_ID }} --paths "/${{ env.CURRENT_VERSION_VALUE }}/*" | |||
|
|
|||
| # TODO: The '/latest' folder is unused. Might be removed in future. | |||
| # TODO: The '/latest' directory is unused. Might be removed in future. | |||
There was a problem hiding this comment.
The comment regarding the unused '/latest' directory is helpful for future maintenance. It might be beneficial to track this as a technical debt item or create a follow-up task to evaluate and potentially remove the unused directory.
Would you like me to open a GitHub issue to track the evaluation and potential removal of the '/latest' directory?
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR
Summary by CodeRabbit
runs-onconfiguration for publishing new releases to useubuntu-latest.github-action-check-size-limitaction.CODEOWNERSfile.sonar.projectVersionfor code quality checks.