chore(release): pulling hotfix-release/3.3.0 into main #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1669) fix: add backward compatibility for storage api
WalkthroughThe recent updates focus on enhancing compatibility and reliability across the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
saikumarrs
approved these changes
Mar 22, 2024
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (9)
package-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.json
Files selected for processing (9)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.ts (2 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (4)
- packages/analytics-js/CHANGELOG_LATEST.md
- packages/loading-scripts/CHANGELOG.md
- packages/sanity-suite/CHANGELOG.md
- sonar-project.properties
Additional comments: 6
packages/loading-scripts/CHANGELOG_LATEST.md (1)
- 1-5: The version and dependency updates are correctly documented and align with the PR objectives.
packages/analytics-js-plugins/CHANGELOG_LATEST.md (1)
- 1-6: The version update and the bug fix for adding backward compatibility for the storage API are correctly documented and align with the PR objectives.
packages/analytics-js-plugins/CHANGELOG.md (1)
- 5-10: The changelog entry for version 3.0.3 correctly documents the bug fix for adding backward compatibility for the storage API. The inclusion of issue and commit links enhances traceability. Well done.
packages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.ts (2)
- 8-8: The replacement of
isNullOrUndefinedwithisFunctionis appropriate for the intended functionality. It's good to see focused utility functions being used for specific checks.- 708-721: The addition of a backward compatibility check for the
keysfunction in the storage engine is well-implemented. It ensures that the functionality remains consistent across different storage engine versions. However, consider the performance implications in environments with a large number of storage items, as iterating over all items could be less efficient than using thekeysmethod.packages/analytics-js/CHANGELOG.md (1)
- 5-9: The changelog entry for version 3.0.3 of
@rudderstack/analytics-jscorrectly documents the dependency update to@rudderstack/analytics-js-pluginsversion 3.0.2. The format follows conventional changelog practices, providing clear and concise information about the changes, including relevant links to GitHub issues and comparisons.
|
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR
Summary by CodeRabbit
analytics-js-pluginsto ensure older versions remain functional.analytics-js-pluginsfor better error handling.CHANGELOG.mdfiles across packages to reflect the latest changes and version updates.sonar-project.propertiesto change the project version, enhancing project analysis and tracking.