Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pulling hotfix-release/3.4.0 into main #1673

Closed
wants to merge 7 commits into from

Conversation

devops-github-rudderstack
Copy link
Contributor

@devops-github-rudderstack devops-github-rudderstack commented Mar 26, 2024

👑 An automated PR

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency issues in analytics-js-integrations and analytics-v1.1 packages to improve package management.
  • New Features
    • Updated the @rudderstack/analytics-js-sanity-suite with the latest rudder-sdk-js version for enhanced analytics capabilities.
  • Chores
    • Updated project version in sonar-project.properties for better project tracking.

Copy link
Contributor

coderabbitai bot commented Mar 26, 2024

Walkthrough

The recent updates span across multiple packages, focusing on dependency management and version increments. Notably, analytics-js-integrations and analytics-v1.1 packages received bug fixes that adjust their dependencies, specifically moving the analytics common package to dev dependencies. Additionally, the @rudderstack/analytics-js-sanity-suite package was updated to include a newer version of a dependency. There's also a general project version bump noted in the configuration for project analysis.

Changes

Files Change Summary
packages/analytics-js-integrations/CHANGELOG.md, packages/analytics-js-integrations/CHANGELOG_LATEST.md Bug fix: Moved analytics common package to dev dependencies.
packages/analytics-v1.1/CHANGELOG.md, packages/analytics-v1.1/CHANGELOG_LATEST.md Bug fix: Moved analytics common package to dev dependencies.
packages/sanity-suite/CHANGELOG.md Updated rudder-sdk-js dependency to 3.0.3.
sonar-project.properties Updated sonar.projectVersion to 3.4.0.

🐇✨
In the land of code, where changes abound,
A rabbit hopped in, with updates it found.
"To dev dependencies, some packages go,
And versions ascend, as improvements show."
With a flick and a hop, it made all align,
"Now onwards we leap, through version 3.9!"
🌟🐾

Warning

Following errors were encountered

  • Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 395f9b9 and 5ae12d4.
Files ignored due to path filters (7)
  • package-lock.json is excluded by: !**/*.json
  • package.json is excluded by: !**/*.json
  • packages/analytics-js-integrations/package.json is excluded by: !**/*.json
  • packages/analytics-js-integrations/project.json is excluded by: !**/*.json
  • packages/analytics-v1.1/package.json is excluded by: !**/*.json
  • packages/analytics-v1.1/project.json is excluded by: !**/*.json
  • packages/sanity-suite/package.json is excluded by: !**/*.json
Files selected for processing (6)
  • packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
  • packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
  • packages/analytics-v1.1/CHANGELOG.md (1 hunks)
  • packages/analytics-v1.1/CHANGELOG_LATEST.md (1 hunks)
  • packages/sanity-suite/CHANGELOG.md (1 hunks)
  • sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (3)
  • packages/analytics-v1.1/CHANGELOG.md
  • packages/sanity-suite/CHANGELOG.md
  • sonar-project.properties
Additional comments: 3
packages/analytics-v1.1/CHANGELOG_LATEST.md (1)
  • 1-6: The changelog entry for version 2.48.6 clearly documents the bug fix related to moving the analytics common package to dev dependencies. Including the commit link is a good practice for traceability.
packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
  • 1-7: The changelog entry for version 3.0.3 is well-documented, highlighting the movement of the analytics common package to dev dependencies. The inclusion of the commit link enhances traceability.
packages/analytics-js-integrations/CHANGELOG.md (1)
  • 5-11: The changelog for version 3.0.3 is clearly documented, maintaining consistency with the CHANGELOG_LATEST.md file. The overall structure of the changelog is commendable, effectively using version comparison links and commit links for detailed traceability.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.90%. Comparing base (395f9b9) to head (5ae12d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   53.90%   53.90%           
=======================================
  Files         461      461           
  Lines       15611    15611           
  Branches     3102     3101    -1     
=======================================
  Hits         8415     8415           
  Misses       5890     5890           
  Partials     1306     1306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.81 KB 15.81 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.64 KB 7.64 KB (0%) 8 KB
Core CJS - NPM 22.45 KB 22.45 KB (0%) 23 KB
Core - NPM 22.55 KB 22.55 KB (0%) 23 KB
Core Legacy - CDN 42.99 KB 42.99 KB (0%) 44 KB
Core - CDN 22.71 KB 22.71 KB (0%) 23 KB
Core (legacy build) - CDN - v1.1 31.52 KB 31.55 KB (+0.1% ▲) 32 KB
Core - NPM - v1.1 31.54 KB 31.53 KB (-0.03% ▼) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.57 KB 98.57 KB (0%) 105 KB

@MoumitaM MoumitaM closed this Mar 26, 2024
@MoumitaM MoumitaM deleted the hotfix-release/3.4.0 branch March 26, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants