Skip to content

chore(release): pull main into develop post release v3.5.0#1682

Merged
saikumarrs merged 3 commits intodevelopfrom
main
Apr 3, 2024
Merged

chore(release): pull main into develop post release v3.5.0#1682
saikumarrs merged 3 commits intodevelopfrom
main

Conversation

@MoumitaM
Copy link
Copy Markdown
Contributor

@MoumitaM MoumitaM commented Apr 3, 2024

PR Description

Please include a summary of the change along with the relevant motivation and context.

Linear task (optional)

Linear task link

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • Bug Fixes
    • Improved ninetailed integration with enhanced page support.
    • Updated mixpanel integration to refine isLoaded and isReady conditions.
  • Chores
    • Updated project version in configuration for better tracking and compliance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2024

Walkthrough

The recent update brings bug fixes to the @rudderstack/analytics-js-integrations package, specifically targeting the ninetailed and mixpanel integrations for improved page support and reliability. Additionally, the project's version in the sonar-project.properties file has been incremented to reflect ongoing development and enhancements.

Changes

File Path Change Summary
.../analytics-js-integrations/... Bug fixes for ninetailed and mixpanel in version 3.0.3.
sonar-project.properties Updated sonar.projectVersion from 3.4.0 to 3.5.0.

🐇✨
In the land of code and byte,
Bugs hop away, out of sight.
With a leap and a bound, versions grow,
Under the watchful eyes, in the soft moon's glow.
🌟📈
Through fields of data, we dash,
Crafting the future, in a flash.
🚀🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.93%. Comparing base (08ab4c1) to head (4fa8cbb).
Report is 5 commits behind head on develop.

Files Patch % Lines
...-integrations/src/integrations/Mixpanel/browser.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1682      +/-   ##
===========================================
+ Coverage    53.90%   53.93%   +0.02%     
===========================================
  Files          461      461              
  Lines        15611    15616       +5     
  Branches      3091     3098       +7     
===========================================
+ Hits          8415     8422       +7     
+ Misses        5907     5878      -29     
- Partials      1289     1316      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 80c76a1 and 4fa8cbb.
Files ignored due to path filters (4)
  • package-lock.json is excluded by !**/package-lock.json, !**/*.json
  • package.json is excluded by !**/*.json
  • packages/analytics-js-integrations/package.json is excluded by !**/*.json
  • packages/analytics-js-integrations/project.json is excluded by !**/*.json
Files selected for processing (3)
  • packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
  • packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
  • sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (1)
  • sonar-project.properties
Additional comments not posted (3)
packages/analytics-js-integrations/CHANGELOG_LATEST.md (2)

6-6: Consider adding more context or a brief description of how the page support was modified for ninetailed to provide clearer insights into the nature of the bug fix.


7-7: Consider providing additional details on how the isLoaded and isReady conditions for mixpanel were updated to help readers understand the impact of these changes.

packages/analytics-js-integrations/CHANGELOG.md (1)

2-15: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [5-276]

Ensure that all integration names and technical terms are consistently spelled and used throughout the changelog to maintain clarity and professionalism. While the static analysis tool flagged several potential issues, most appear to be false positives related to the specific context of this document.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2024

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.81 KB 15.81 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.64 KB 7.64 KB (0%) 8 KB
Core CJS - NPM 22.45 KB 22.45 KB (0%) 23 KB
Core - NPM 22.55 KB 22.55 KB (0%) 23 KB
Core Legacy - CDN 42.99 KB 42.99 KB (0%) 44 KB
Core - CDN 22.71 KB 22.71 KB (0%) 23 KB
Core (legacy build) - CDN - v1.1 31.55 KB 31.55 KB (0%) 32 KB
Core - NPM - v1.1 31.53 KB 31.53 KB (0%) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.45 KB 98.45 KB (0%) 105 KB

@saikumarrs saikumarrs merged commit 7b84a6a into develop Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants