-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove MutationObserver and make polyfill checks consistent #1688
fix: remove MutationObserver and make polyfill checks consistent #1688
Conversation
WalkthroughThe recent updates focus on refining polyfill configurations and improving issue templates for bug reports and feature requests. Additionally, adjustments in the detection capabilities for the analytics SDK enhance compatibility with modern web technologies. These changes streamline developer interactions and ensure the SDK remains robust across diverse environments. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Additional comments not posted (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1688 +/- ##
===========================================
- Coverage 53.93% 53.92% -0.01%
===========================================
Files 461 461
Lines 15616 15615 -1
Branches 3109 3100 -9
===========================================
- Hits 8422 8421 -1
- Misses 5840 5869 +29
+ Partials 1354 1325 -29 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
size-limit report 📦
|
PR Description
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-1589/remove-mutationobserver-polyfill-js-sdk
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security