chore(release): pulling release/3.6.0 into main #1690
Conversation
* fix: remove unnecessary window globals declarations * fix: further clean up declaration files
* fix: remove MutationObserver and make polyfill checks consistent * chore: update github templates
devops-github-rudderstack
requested review from
shrouti1507 and
sandeepdsvs
as code owners
devops-github-rudderstack
requested review from
koladilip,
mihir-4116 and
a team
as code owners
WalkthroughThis update primarily involves version bumps across various RudderStack Analytics JS SDK packages and enhancements in polyfills, error handling, and code clean-up. Changes include updating dependency versions, refining error messages from errors to warnings, removing unnecessary global declarations, and adjusting polyfill checks for better consistency and performance. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (25)
Files skipped from review due to trivial changes (7)
Additional comments not posted (15)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
- Coverage 53.93% 53.92% -0.01%
==========================================
Files 461 461
Lines 15616 15615 -1
Branches 3098 3097 -1
==========================================
- Hits 8422 8421 -1
Misses 5878 5878
Partials 1316 1316 ☔ View full report in Codecov by Sentry. |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Actionable comments outside the diff hunks (1)
packages/analytics-js/CHANGELOG.md (1)
Line range hint
224-330: Address multiple consecutive blank lines and incorrect heading levels throughout the document.- Multiple consecutive blank lines found in various sections. Please reduce them to a single blank line. - Correct the heading levels to increment by one level at a time.
| @@ -2,6 +2,14 @@ | |||
|
|
|||
| This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver). | |||
|
|
|||
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Reduce multiple consecutive blank lines to improve readability.
- Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].3...@rudderstack/[email protected].4) (2024-04-12) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * ninetailed: modify page support ([#1677](https://github.com/rudderlabs/rudder-sdk-js/issues/1677)) ([e45ef06](https://github.com/rudderlabs/rudder-sdk-js/commit/e45ef06186cb4dc1d0568f2b39d8e786d278390a)) | ||
| * updated isLoaded and isReady conditions for mixpanel ([#1650](https://github.com/rudderlabs/rudder-sdk-js/issues/1650)) ([80c76a1](https://github.com/rudderlabs/rudder-sdk-js/commit/80c76a1f7f27a93930a6146730ac94d945b19b25)) | ||
| * making the error message as warn ([#1686](https://github.com/rudderlabs/rudder-sdk-js/issues/1686)) ([56e34be](https://github.com/rudderlabs/rudder-sdk-js/commit/56e34be3575f66531bfe4910ff4aa970ed2ee208)) |
There was a problem hiding this comment.
Please remove the extra blank lines to adhere to standard markdown practices.
3c3
<
---
>
8c8
<
---
> Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |
| ### Bug Fixes | |
| * ninetailed: modify page support ([#1677](https://github.com/rudderlabs/rudder-sdk-js/issues/1677)) ([e45ef06](https://github.com/rudderlabs/rudder-sdk-js/commit/e45ef06186cb4dc1d0568f2b39d8e786d278390a)) | |
| * updated isLoaded and isReady conditions for mixpanel ([#1650](https://github.com/rudderlabs/rudder-sdk-js/issues/1650)) ([80c76a1](https://github.com/rudderlabs/rudder-sdk-js/commit/80c76a1f7f27a93930a6146730ac94d945b19b25)) | |
| * making the error message as warn ([#1686](https://github.com/rudderlabs/rudder-sdk-js/issues/1686)) ([56e34be](https://github.com/rudderlabs/rudder-sdk-js/commit/56e34be3575f66531bfe4910ff4aa970ed2ee208)) | |
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |
| ### Bug Fixes | |
| * making the error message as warn ([#1686](https://github.com/rudderlabs/rudder-sdk-js/issues/1686)) ([56e34be](https://github.com/rudderlabs/rudder-sdk-js/commit/56e34be3575f66531bfe4910ff4aa970ed2ee208)) |
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].3...@rudderstack/[email protected].4) (2024-04-12) | ||
|
|
||
| ### Dependency Updates | ||
|
|
||
| * `@rudderstack/analytics-js` updated to version `3.0.2` | ||
| * `@rudderstack/analytics-js` updated to version `3.0.3` | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) | ||
|
|
There was a problem hiding this comment.
Please remove the extra blank line to adhere to standard markdown practices.
11c11
<
---
> Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |
| ### Dependency Updates | |
| * `@rudderstack/analytics-js` updated to version `3.0.2` | |
| * `@rudderstack/analytics-js` updated to version `3.0.3` | |
| ### Bug Fixes | |
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) | |
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |
| ### Dependency Updates | |
| * `@rudderstack/analytics-js` updated to version `3.0.3` | |
| ### Bug Fixes | |
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) |
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].3...@rudderstack/[email protected].4) (2024-04-12) | ||
|
|
||
| ### Dependency Updates | ||
|
|
||
| * `@rudderstack/analytics-js-plugins` updated to version `3.0.2` | ||
| ### Bug Fixes | ||
|
|
||
| * remove MutationObserver and make polyfill checks consistent ([#1688](https://github.com/rudderlabs/rudder-sdk-js/issues/1688)) ([51b42fe](https://github.com/rudderlabs/rudder-sdk-js/commit/51b42fe51a5fbfa79df23b9b36095cc494dbcaa1)) | ||
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) | ||
|
|
There was a problem hiding this comment.
Please remove the extra blank lines to adhere to standard markdown practices.
3c3
<
---
>
9c9
<
---
> Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |
| ### Dependency Updates | |
| * `@rudderstack/analytics-js-plugins` updated to version `3.0.2` | |
| ### Bug Fixes | |
| * remove MutationObserver and make polyfill checks consistent ([#1688](https://github.com/rudderlabs/rudder-sdk-js/issues/1688)) ([51b42fe](https://github.com/rudderlabs/rudder-sdk-js/commit/51b42fe51a5fbfa79df23b9b36095cc494dbcaa1)) | |
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) | |
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |
| ### Bug Fixes | |
| * remove MutationObserver and make polyfill checks consistent ([#1688](https://github.com/rudderlabs/rudder-sdk-js/issues/1688)) ([51b42fe](https://github.com/rudderlabs/rudder-sdk-js/commit/51b42fe51a5fbfa79df23b9b36095cc494dbcaa1)) | |
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) |
size-limit report 📦
|
👑 An automated PR
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Version Updates
Refactor