Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/3.9.0 into main #1727

Merged
merged 28 commits into from
May 27, 2024
Merged

chore(release): pull release/3.9.0 into main #1727

merged 28 commits into from
May 27, 2024

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

MoumitaM and others added 26 commits May 13, 2024 12:14
* chore: upgrade dependencis to latest

* fix: sonarjs eslint config

* fix: nx patch

* refactor: address ai bot review comments

* chore: clean up workflows and fix sanity suite deployment

* chore: upgrade dependencis to latest

* chore: use consistent naming for deployment jobs

* feat: sync session data from storage

* feat: add unit tests to improve coverage

* fix: remove unwanted user id constraint in workflows

* chore: upgrade dependencis to latest and add inline documentation

* fix: use default constants

* chore: add browser test

* chore: add implicit dependencies and targets cache configuration

* chore: address ai bot review comments for test cases

* fix: session creation

* fix: browser test

* fix: use namedInputs
* docs: update cla link

* chore: remove unused link

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…1699)

Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases)
- [Commits](slackapi/slack-github-action@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(analytics-js-service-worker): auto append batch endpoint

* fix: replace setImmediate implementation with Promise

* test: add more tests for improving coverage

* fix: regex

* chore: fix sdk version in slack notification
* chore: address coderabbit comments for ninetailed examples

* feat: onboard bingads enhanced conversions

* fix: sonar cloud regex

* chore: added docs link
* feat: added new load option to set cookies from serverside

* chore: address review comments

* chore: modify configuration for getAsyncData fn

* chore: updated cookie setter provider

* chore: address review comments

* chore: address review comment

* chore: fix error handling to remove cookies if value is empty

* chore: address review comment

* chore: update cb fn

* chore: add new type for callback

* chore: update test case

* chore: update test case

* chore: removed unnecessary code

* chore: more test cases added

* chore: removed code for client side cookie removal and update test cases

* chore: use current page url as the base url for cookie request

* chore: removed unnecessary only statement

* chore: review comment address

* chore: review comment address

* chore: use nullish coalescing operator

* chore: enhance test case

* chore: remove leading slash from provided endpoint
* chore: fix github publish action

* chore: fix slack notifications
feat: intrduce a new config for if hashing is required
* feat: google ads identify call suppport for enhanced conversion

* chore: address comment

* chore: address comments

* chore: update toggle support from config

* chore: address review comments

* Update packages/analytics-js-integrations/src/integrations/GoogleAds/browser.js

Co-authored-by: Sudip Paul <[email protected]>

* chore: address review comments

* chore: fix sonar issue

---------

Co-authored-by: Sudip Paul <[email protected]>
* fix: update reddit_pixel identify call

* feat: update redditPixel with advanced mapping and remove discrepency with device mode

* chore: address comment by coderabbit

* chore: add unit tests

* chore: address comment

* chore: add doc link to reddit_pixel/browser.js

* chore: add os verification

* chore: fix lint issues and add test case
Copy link
Contributor

coderabbitai bot commented May 24, 2024

Important

Review Skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tip

Early Access Features
  • gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 88.21293% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 54.94%. Comparing base (0f89b7d) to head (e5ebc44).

Files Patch % Lines
...tegrations/src/integrations/RedditPixel/browser.js 12.50% 5 Missing and 2 partials ⚠️
...s-js/src/components/configManager/ConfigManager.ts 46.15% 7 Missing ⚠️
...omponents/userSessionManager/UserSessionManager.ts 93.93% 1 Missing and 3 partials ⚠️
...integrations/src/integrations/RedditPixel/utils.js 88.46% 1 Missing and 2 partials ⚠️
...alytics-js/src/components/utilities/loadOptions.ts 25.00% 2 Missing and 1 partial ⚠️
...integrations/src/integrations/GoogleAds/browser.js 85.71% 2 Missing ⚠️
...mon/src/constants/integrations/Criteo/constants.ts 0.00% 1 Missing ⚠️
...-js-integrations/src/integrations/BingAds/utils.js 96.77% 1 Missing ⚠️
...js-integrations/src/integrations/Criteo/browser.js 0.00% 1 Missing ⚠️
...s-integrations/src/integrations/GoogleAds/utils.js 96.15% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   54.27%   54.94%   +0.67%     
==========================================
  Files         462      465       +3     
  Lines       15655    15869     +214     
  Branches     3114     3182      +68     
==========================================
+ Hits         8497     8720     +223     
- Misses       5812     5859      +47     
+ Partials     1346     1290      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 24, 2024

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.78 KB 15.82 KB (+0.31% ▲) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.69 KB (-0.31% ▼) 6 KB
Core ESM - NPM 7.68 KB 7.65 KB (-0.5% ▼) 8 KB
Core CJS - NPM 22.89 KB 23.45 KB (+2.48% ▲) 23.7 KB
Core - NPM 23.02 KB 23.55 KB (+2.28% ▲) 23.7 KB
Core Legacy - CDN 43.37 KB 44.04 KB (+1.56% ▲) 44.2 KB
Core - CDN 23.16 KB 23.76 KB (+2.58% ▲) 24 KB
Core (legacy build) - CDN - v1.1 31.53 KB 31.47 KB (-0.2% ▼) 32 KB
Core - NPM - v1.1 31.55 KB 31.52 KB (-0.08% ▼) 32 KB
Service Worker Module 22.64 KB 23.15 KB (+2.25% ▲) 24 KB
All Integrations (legacy build) - CDN 98.69 KB 99.56 KB (+0.88% ▲) 105 KB

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
83.8% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

@saikumarrs saikumarrs merged commit 31d597a into main May 27, 2024
9 of 11 checks passed
@saikumarrs saikumarrs deleted the release/3.9.0 branch May 27, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants