Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/3.31.0-SDK-2229 into main #1830

Merged
merged 15 commits into from
Aug 19, 2024

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

This PR is created automatically by the GitHub Actions workflow to merge the release branch into the main branch.

Linear Ticket:
https://linear.app/rudderstack/issue/SDK-2229

saikumarrs and others added 15 commits August 5, 2024 14:43
* chore: fix globalThis polyfill in loading snippet

* chore: replace var with let
* feat: onboarded XPixel Integration

* chore: tmp commit for test check

* chore: updated testcases and function

* chore: new testcases added

* chore: testcases updated

* chore: exclude integration constants from coverage

* chore: testcase added

* chore: updated size limit

* chore: added a comman function and updated script

* chore: added comman function

* chore: import fix

* chore: updated return

* chore: minor change for eventsMapping

* chore: minor change for page call

* chore: sonar conflicts resolved

---------

Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
@devops-github-rudderstack devops-github-rudderstack requested a review from a team August 16, 2024 09:47
@devops-github-rudderstack devops-github-rudderstack requested a review from a team as a code owner August 16, 2024 09:47
Copy link
Contributor

coderabbitai bot commented Aug 16, 2024

Important

Review skipped

Ignore keyword(s) in the title.

Ignored keywords (1)
  • chore(release)

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
84.4% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (0d14a5a) to head (12e6235).
Report is 16 commits behind head on main.

Files Patch % Lines
...mon/src/constants/integrations/XPixel/constants.js 0.00% 12 Missing ⚠️
...on/src/constants/integrations/integration_cname.js 0.00% 1 Missing ⚠️
...s-js-integrations/src/integrations/XPixel/utils.js 96.55% 1 Missing ⚠️
...nalytics-js-integrations/src/integrations/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   56.70%   56.79%   +0.09%     
==========================================
  Files         473      476       +3     
  Lines       16121    16191      +70     
  Branches     3233     3236       +3     
==========================================
+ Hits         9141     9196      +55     
- Misses       5713     5728      +15     
  Partials     1267     1267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Cookies Utils - Legacy - NPM (ESM) 1.54 KB 1.54 KB (0%) 2 KB
Cookies Utils - Legacy - NPM (CJS) 1.75 KB 1.75 KB (0%) 2 KB
Cookies Utils - Legacy - NPM (UMD) 1.53 KB 1.53 KB (0%) 2 KB
Cookies Utils - Modern - NPM (ESM) 1.17 KB 1.17 KB (0%) 1.5 KB
Cookies Utils - Modern - NPM (CJS) 1.4 KB 1.4 KB (0%) 1.5 KB
Cookies Utils - Modern - NPM (UMD) 1.16 KB 1.16 KB (0%) 1.5 KB
Plugins Module Federation Mapping - Legacy - CDN 332 B 332 B (0%) 512 B
Plugins - Legacy - CDN 15.88 KB 15.88 KB (0%) 16 KB
Plugins Module Federation Mapping - Modern - CDN 331 B 331 B (0%) 512 B
Plugins - Modern - CDN 7.19 KB 7.19 KB (0%) 7.5 KB
Common - No bundling 15.89 KB 15.93 KB (+0.27% ▲) 16.5 KB
Service Worker - Legacy - NPM (ESM) 30.45 KB 30.41 KB (-0.15% ▼) 30 KB
Service Worker - Legacy - NPM (CJS) 30.7 KB 30.65 KB (-0.16% ▼) 30 KB
Service Worker - Legacy - NPM (UMD) 30.42 KB 30.39 KB (-0.1% ▼) 30 KB
Service Worker - Modern - NPM (ESM) 25.5 KB 25.51 KB (+0.03% ▲) 25 KB
Service Worker - Modern - NPM (CJS) 25.76 KB 25.76 KB (-0.01% ▼) 25 KB
Service Worker - Modern - NPM (UMD) 25.5 KB 25.53 KB (+0.12% ▲) 25 KB
Core (v1.1) - NPM (ESM) 29.79 KB 29.84 KB (+0.17% ▲) 32 KB
Core (v1.1) - NPM (CJS) 29.92 KB 29.97 KB (+0.19% ▲) 32 KB
Core (v1.1) - NPM (UMD) 29.86 KB 29.85 KB (-0.04% ▼) 32 KB
Core (Content Script - v1.1) - NPM (ESM) 29.33 KB 29.36 KB (+0.1% ▲) 30 KB
Core (Content Script - v1.1) - NPM (CJS) 29.55 KB 29.51 KB (-0.12% ▼) 30 KB
Core (Content Script - v1.1) - NPM (UMD) 29.36 KB 29.42 KB (+0.2% ▲) 30 KB
Core - Legacy - CDN 47.42 KB 47.38 KB (-0.08% ▼) 48 KB
Core - Modern - CDN 24.1 KB 24.12 KB (+0.1% ▲) 24.5 KB
Load Snippet 732 B 720 B (-1.64% ▼) 1 KB
Core - Legacy - NPM (ESM) 47.26 KB 47.29 KB (+0.07% ▲) 47.5 KB
Core - Legacy - NPM (CJS) 47.56 KB 47.49 KB (-0.16% ▼) 48 KB
Core - Legacy - NPM (UMD) 47.28 KB 47.26 KB (-0.04% ▼) 47.5 KB
Core - Modern - NPM (ESM) 23.81 KB 23.79 KB (-0.06% ▼) 24.5 KB
Core - Modern - NPM (CJS) 24.06 KB 24.09 KB (+0.14% ▲) 24.5 KB
Core - Modern - NPM (UMD) 23.89 KB 23.84 KB (-0.21% ▼) 24.5 KB
Core (Bundled) - Legacy - NPM (ESM) 47.26 KB 47.29 KB (+0.07% ▲) 47.5 KB
Core (Bundled) - Legacy - NPM (CJS) 47.53 KB 47.5 KB (-0.06% ▼) 48 KB
Core (Bundled) - Legacy - NPM (UMD) 47.28 KB 47.26 KB (-0.04% ▼) 47.5 KB
Core (Bundled) - Modern - NPM (ESM) 38.57 KB 38.55 KB (-0.07% ▼) 39 KB
Core (Bundled) - Modern - NPM (CJS) 38.8 KB 38.79 KB (-0.04% ▼) 39 KB
Core (Bundled) - Modern - NPM (UMD) 38.58 KB 38.54 KB (-0.12% ▼) 39 KB
Core (Content Script) - Legacy - NPM (ESM) 46.72 KB 46.76 KB (+0.09% ▲) 47 KB
Core (Content Script) - Legacy - NPM (CJS) 47 KB 47.02 KB (+0.05% ▲) 47.5 KB
Core (Content Script) - Legacy - NPM (UMD) 46.79 KB 46.77 KB (-0.04% ▼) 47 KB
Core (Content Script) - Modern - NPM (ESM) 38.02 KB 38.01 KB (-0.04% ▼) 38.5 KB
Core (Content Script) - Modern - NPM (CJS) 38.27 KB 38.23 KB (-0.12% ▼) 38.5 KB
Core (Content Script) - Modern - NPM (UMD) 37.99 KB 38.01 KB (+0.05% ▲) 38.5 KB
All Integrations - Legacy - CDN 93.92 KB 94.29 KB (+0.4% ▲) 95.3 KB
All Integrations - Modern - CDN 88.8 KB 89.38 KB (+0.65% ▲) 91 KB

@saikumarrs saikumarrs merged commit e09a8b9 into main Aug 19, 2024
9 of 11 checks passed
@saikumarrs saikumarrs deleted the release/3.31.0-SDK-2229 branch August 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants