Merged
Conversation
Closed
✅ Deploy Preview for cutetix-admin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sy-filis
reviewed
Mar 4, 2026
|
|
||
| #defaultMenu: MenuItem[] = [ | ||
| this.#getMenuItem('My events', 'my-events', faCalendarDay, () => this.getSubItemsByPath('my-events')), | ||
| ].filter(o => o); |
Member
Author
There was a problem hiding this comment.
To jsem si říkal taky, má to odjebat nevalidní objekty jako null, atd.
sy-filis
reviewed
Mar 4, 2026
Comment on lines
+26
to
+40
| build(currentUrl: string = ''): MenuItem[] { | ||
| if (this.#adminMode.status()) { | ||
| // user is admin and should have access to all things | ||
| return this.#adminMenu.filter(o => o); | ||
| } | ||
|
|
||
| // user has restricted access | ||
| let menu: MenuItem[] = []; | ||
|
|
||
| for (let i = 0; i < this.#adminMenu.length; i++) { | ||
| const menuItem = this.#adminMenu[i]; | ||
| if (currentUrl.startsWith(`/${menuItem.link}`)) { | ||
| menu.push(menuItem); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Okomentovat, ale možná to nechápu, protože nevím, jaká je architektura toho menu buildingu.
Member
Author
There was a problem hiding this comment.
Přidal jsem komentáře, snad je to teď lepší.
sy-filis
reviewed
Mar 4, 2026
sy-filis
reviewed
Mar 4, 2026
sy-filis
reviewed
Mar 4, 2026
Collaborator
There was a problem hiding this comment.
Hele, toto Ti celé přepíšu doma na komplu... :)
Co-authored-by: Filip Zukal <130696213+sy-filis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.