demo: Add back ability to use query parameters to load specific sample #22006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-web
danielhjacobs
force-pushed
the
add-query-params-demo
branch
from
e61d4f0 to
067d2f4
Compare
danielhjacobs
force-pushed
the
add-query-params-demo
branch
from
067d2f4 to
b027370
Compare
kjarosh
reviewed
Oct 23, 2025
Comment on lines
+83
to
+85
| swf.location === fileParam || | ||
| swf.location.replace(/^swfs\//, "") === | ||
| fileParam, |
There was a problem hiding this comment.
Why do we have this duality here?
There was a problem hiding this comment.
I wasn't sure if we'd want ?file=bitey1.swf, this lets it work. That was the real path to the SWF 5 years ago, but now it's swfs/bitey1.swf
There was a problem hiding this comment.
Can't we just remove the swfs/ prefix and make it work the same way as before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.