avm1: Avoid storing owned data in Activation
#22048
Merged
+53
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
kjarosh
reviewed
Oct 27, 2025
Lord-McSweeney
approved these changes
Oct 27, 2025
moulins
force-pushed
the
avm1-activation-refs
branch
from
6f967e3 to
d1c1d5f
Compare
…tion` This avoid a `Rc::clone` call on rescopes (e.g. for `with` or `try/catch`) and simplifies `Activation`'s drop glue.
`Some(&[])` could never happen, and allocating an empty `Box<[_]>` is free, so we can treat `&[]` as "has no local registers". Also remove a misleading comment concerning local register #0 (which *does* exist, even though most AS2 compilers don't like to use it for some reason).
We can instead always store a `&'a str`.
moulins
force-pushed
the
avm1-activation-refs
branch
from
d1c1d5f to
a958f43
Compare
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep local registers and activation names as bare references in
Activation, leaving the caller responsible for allocating them if necessary.As many activations have static names and/or no local registers (and as such don't need to allocate), this improves performance (up to a 5% reduction in wall-time in AVM1 benchmarks).
Possible further improvements (which would require unsafe code, probably):
Gcs for the scope linked-list; this would require some way of lazily allocating scopes when they get captured byDefineFunctionclosures.