-
-
Notifications
You must be signed in to change notification settings - Fork 926
tests: Import actionscript.all tests from gnash #22050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some tests fail when running coverage: They actually fail locally too for me. |
|
I think something's wrong with the We might want to write them in such a way that they rarely produce output, or (better IMO) modify them not to iterate over all integers, but only over edge cases. |
|
Regarding |
Yes. That exact ttf file was used on Windows to replace Times New Roman for those tests. |
|
Let's remove caseconv for now to unblock the rest of the tests, whilst we think of something better there |
dad42dd to
b688df5
Compare
On Windows? IIUC FP does not use fontconfig on Windows, no? |
Correct, I had to rename the font to Times New Roman, install it as a user font, and verify that the values changed when I did so, so it's picking up the custom font instead of the system font. |
|
I did some perf testing of those tests, and:
I think we should drop
|
|
Surprising that argstest takes so long. It's actually one of the more useful tests as it's essentially checking everything doesn't panic (and already caught two big issues). Do you know if it's the printing or the iteration/calling that is so slow? It's of course not that slow for me, so I'm guessing that's all the instrumentation 😅 |
|
Hmmm, you're right, something weird must have happened during my testing as now it runs in acceptable time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, those look like very useful tests!
b688df5 to
2a80b20
Compare
|
You fixed some tests! :D |
|
And broke one, it seems 🤔 Video-v5 no longer passes. I'll merge it as known-failure though |
2a80b20 to
06a3a05
Compare
06a3a05 to
0f02ad5
Compare
Once again, way too many tests to detail - sadly.
All these tests surround a specific AS2 class, and the behaviour often changes per FP version - in these cases the output is in e.g.
fp10subfolder.All tests are ran on Windows using FP 9 -> 32. A
SharedObjecttest was skipped as we don't have support for this in out test framework yet.Summary is: