avm2: Bring StageObject's DisplayObject creation into the same place#9893
Closed
Dinnerbone wants to merge 10 commits intoruffle-rs:masterfrom
Closed
avm2: Bring StageObject's DisplayObject creation into the same place#9893Dinnerbone wants to merge 10 commits intoruffle-rs:masterfrom
Dinnerbone wants to merge 10 commits intoruffle-rs:masterfrom
Conversation
de10c1c to
097e0d7
Compare
…t up a DO if it isn't already
097e0d7 to
a4847dc
Compare
Contributor
Collaborator
|
Obsoleted by #11084. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't entirely solve the ordering issue, but it's a step towards it. Now there's a way to get and set up the DO regardless of what it is, and the next step is to figure out how to do that in initializer time.
I tried not to change the logic any, just moved things around.