Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map legend position to layers #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BalzGuenat
Copy link

No description provided.

@ruiqimao
Copy link
Owner

Could we get the help icons to line up on the right? Also figure out a way to get the button centered, since it looks kind of awkward off to the side. And the text in the textboxes centered.

We probably also want these settings saved in the json, which means the serialize() and deserialize() functions need to be changed while maintaining compatibility with older json files.

And one more thing, can we get all the functions fully documented? There are a few that don't have docstrings above them.

Other than that, looks like it works. Good job!

@BalzGuenat
Copy link
Author

Thanks for the comments. I implemented your suggestions. (De-)Serialization code did not have to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants