Skip to content

Improvements - #137

Merged
rulasg merged 10 commits into
mainfrom
improvements
Sep 15, 2025
Merged

Improvements#137
rulasg merged 10 commits into
mainfrom
improvements

Conversation

@rulasg

@rulasg rulasg commented Sep 15, 2025

Copy link
Copy Markdown
Owner

No description provided.


}

function Remove-Item{

Check warning

Code scanning / PSScriptAnalyzer

'Remove-Item' is a cmdlet that is included with PowerShell (version core-6.1.0-windows) whose definition should not be overridden Warning

'Remove-Item' is a cmdlet that is included with PowerShell (version core-6.1.0-windows) whose definition should not be overridden

}

function Remove-Item{

Check warning

Code scanning / PSScriptAnalyzer

Function 'Remove-Item' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. Warning

Function 'Remove-Item' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
Comment thread private/projectDatabase/project_database_Item.ps1 Fixed
Comment thread private/projectDatabase/project_database_Item.ps1 Fixed
Comment thread public/project_item.ps1
Save-ProjectDatabase -Database $db
}

function Remove-ProjectItem{

Check warning

Code scanning / PSScriptAnalyzer

Function 'Remove-ProjectItem' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. Warning

Function 'Remove-ProjectItem' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
Comment thread public/project_item.ps1 Fixed
Comment thread public/project_item.ps1 Fixed
Comment thread public/project_item.ps1
begin{
($Owner,$ProjectNumber) = Get-OwnerAndProjectNumber -Owner $Owner -ProjectNumber $ProjectNumber
if([string]::IsNullOrWhiteSpace($owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber)){ "Owner and ProjectNumber are required" | Write-MyError; return $null}

Check notice

Code scanning / PSScriptAnalyzer

Line has trailing whitespace Note

Line has trailing whitespace
Comment thread public/project_item.ps1
($Owner,$ProjectNumber) = Get-OwnerAndProjectNumber -Owner $Owner -ProjectNumber $ProjectNumber
if([string]::IsNullOrWhiteSpace($owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber)){ "Owner and ProjectNumber are required" | Write-MyError; return $null}


Check notice

Code scanning / PSScriptAnalyzer

Line has trailing whitespace Note

Line has trailing whitespace
Comment thread public/project_item.ps1
}
if($null -eq $item){
"Item [$ItemId] not found in cache, fetching from API" | Write-Verbose

Check notice

Code scanning / PSScriptAnalyzer

Line has trailing whitespace Note

Line has trailing whitespace
Comment thread public/project_item.ps1
Set-ProjectItem -Owner $Owner -ProjectNumber $ProjectNumber -Item $item
return $item
}

Check notice

Code scanning / PSScriptAnalyzer

Line has trailing whitespace Note

Line has trailing whitespace
Comment thread public/project_item.ps1
begin{
($Owner,$ProjectNumber) = Get-OwnerAndProjectNumber -Owner $Owner -ProjectNumber $ProjectNumber
if([string]::IsNullOrWhiteSpace($owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber)){ "Owner and ProjectNumber are required" | Write-MyError; return $null}

Check notice

Code scanning / PSScriptAnalyzer

Line has trailing whitespace Note

Line has trailing whitespace
@rulasg
rulasg merged commit 17dad69 into main Sep 15, 2025
3 checks passed
@rulasg
rulasg deleted the improvements branch September 15, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants