fix: return actual source nodes with compact and refine response synt… #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b89cae The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@GunnarHolwerda is attempting to deploy a commit to the LlamaIndex Team on Vercel. A member of the Team first needs to authorize it. |
GunnarHolwerda
commented
Dec 7, 2024
Comment on lines
+80
to
+89
| async getResponse( | ||
| query: MessageContent, | ||
| nodes: NodeWithScore[], | ||
| stream: true, | ||
| ): Promise<AsyncIterable<EngineResponse>>; | ||
| async getResponse( | ||
| query: MessageContent, | ||
| nodes: NodeWithScore[], | ||
| stream: false, | ||
| ): Promise<EngineResponse>; |
There was a problem hiding this comment.
Added these signatures so that I didn't have to do more type jumbling after grabbing the original response and transforming it. If this is not accurate please let me know, but based on my knowledge if stream = true it will always be an AsyncIterable.
GunnarHolwerda
force-pushed
the
fix_compact_refine_source_nodes
branch
from
bdd6e90 to
cfed16d
Compare
…hesizer Before we were only returning the packed text chunks in EngineResponse.sourceNodes for this response synthesizer. This is different than how every other synthesizer works.
GunnarHolwerda
force-pushed
the
fix_compact_refine_source_nodes
branch
from
cfed16d to
57eb4e7
Compare
@llamaindex/autotool
@llamaindex/cloud
@llamaindex/community
@llamaindex/core
@llamaindex/experimental
@llamaindex/env
llamaindex
@llamaindex/node-parser
@llamaindex/readers
@llamaindex/wasm-tools
@llamaindex/workflow
@llamaindex/anthropic
@llamaindex/deepinfra
@llamaindex/clip
@llamaindex/groq
@llamaindex/huggingface
@llamaindex/ollama
@llamaindex/openai
@llamaindex/portkey-ai
@llamaindex/vercel
@llamaindex/replicate
@llamaindex/vllm
commit: |
himself65
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates the
RefineresponseSynthesizer to return thesourceNodesin the response as the original nodes that were provided to the synthesizer. This persists the behavior of it prior to 0.5.20 and the other synthesizers whereEngineResponse.sourceNodesis set to the value of the original source nodes that were provided. With the prior implementation it was returning the packed text chunks which would lose context of the document information.Fixes: #1552