Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lockfile compatibility issue with pnpm #169

Closed
wants to merge 17 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Oct 31, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR addresses the issue where the lockfile is not compatible with the current version of pnpm in the LlamaIndexTS repository. The issue occurs when contributors try to install packages using [email protected] as specified in the package.json file. The existing lockfile is not compatible with this version, resulting in warnings and failed package installations.

To resolve this issue, this PR updates the CONTRIBUTING.md file to provide guidance on how to handle lockfile compatibility issues. Contributors are instructed to delete the existing lockfile and run pnpm install to generate a new lockfile if they encounter compatibility issues with their version of pnpm.

Summary of Changes

  • Added a section in the 'Getting Started' part of the CONTRIBUTING.md file to guide contributors on handling lockfile compatibility issues.
  • Instructed contributors to delete the existing lockfile and run pnpm install to generate a new lockfile if they encounter compatibility issues with their version of pnpm.

Fixes #168.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

sweep-ai bot commented Oct 31, 2023

Sandbox Executions

  • Check CONTRIBUTING.md
Sandbox logs for
npm install -g pnpm 1/5 ✓
changed 1 package in 5s
1 package is looking for funding
  run `npm fund` for details
pnpm i 2/5 ✓
Scope: all 6 workspace projects
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1741
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 1741, reused 0, downloaded 39, added 30
Progress: resolved 1741, reused 0, downloaded 286, added 286
Progress: resolved 1741, reused 0, downloaded 613, added 610
Progress: resolved 1741, reused 0, downloaded 908, added 904
Progress: resolved 1741, reused 0, downloaded 1087, added 1079
Progress: resolved 1741, reused 0, downloaded 1294, added 1296
Progress: resolved 1741, reused 0, downloaded 1394, added 1392
Progress: resolved 1741, reused 0, downloaded 1446, added 1439
Progress: resolved 1741, reused 0, downloaded 1678, added 1667
Progress: resolved 1741, reused 0, downloaded 1737, added 1741, done
.../node_modules/core-js-pure postinstall$ node -e "try{require('./postinstall')}catch(e){}"
.../[email protected]/node_modules/core-js postinstall$ node -e "try{require('./postinstall')}catch(e){}"
.../node_modules/core-js-pure postinstall: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
.../node_modules/core-js-pure postinstall: The project needs your help! Please consider supporting core-js:
.../node_modules/core-js-pure postinstall: > https://opencollective.com/core-js 
.../node_modules/core-js-pure postinstall: > https://patreon.com/zloirock 
.../node_modules/core-js-pure postinstall: > https://boosty.to/zloirock 
.../node_modules/core-js-pure postinstall: > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz 
.../node_modules/core-js-pure postinstall: I highly recommend reading this: https://github.com/zloirock/core-js/blob/master/docs/2023-02-14-so-whats-next.md 
.../node_modules/core-js-pure postinstall: Done
.../[email protected]/node_modules/core-js postinstall: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
.../[email protected]/node_modules/core-js postinstall: The project needs your help! Please consider supporting core-js:
.../[email protected]/node_modules/core-js postinstall: > https://opencollective.com/core-js 
.../[email protected]/node_modules/core-js postinstall: > https://patreon.com/zloirock 
.../[email protected]/node_modules/core-js postinstall: > https://boosty.to/zloirock 
.../[email protected]/node_modules/core-js postinstall: > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz 
.../[email protected]/node_modules/core-js postinstall: I highly recommend reading this: https://github.com/zloirock/core-js/blob/master/docs/2023-02-14-so-whats-next.md 
.../[email protected]/node_modules/core-js postinstall: Done
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../[email protected]/node_modules/esbuild postinstall: Done
dependencies:
+ @changesets/cli 2.26.2
devDependencies:
+ @turbo/gen 1.10.16
+ @types/jest 29.5.6
+ eslint 8.52.0
+ eslint-config-custom 0.0.0 <- packages/eslint-config-custom
+ husky 8.0.3
+ jest 29.7.0
+ prettier 3.0.3
+ prettier-plugin-organize-imports 3.2.3
+ ts-jest 29.1.1
+ turbo 1.10.16
. prepare$ husky install
. prepare: husky - Git hooks installed
. prepare: Done
Done in 12.4s
pnpm add --save-dev prettier -w 3/5 ✓
Progress: resolved 0, reused 1, downloaded 0, added 0
Progress: resolved 133, reused 118, downloaded 0, added 0
Progress: resolved 448, reused 408, downloaded 0, added 0
Progress: resolved 1022, reused 988, downloaded 0, added 0
Progress: resolved 1769, reused 1735, downloaded 0, added 0
 WARN  3 deprecated subdependencies found: [email protected], [email protected], [email protected]
Packages: +8 -8
++++++++--------
Progress: resolved 1771, reused 1737, downloaded 0, added 8
Progress: resolved 1771, reused 1737, downloaded 0, added 8, done
Done in 7.4s
pnpx prettier --write CONTRIBUTING.md 4/5 ✓
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
CONTRIBUTING.md 51ms
pnpm eslint --fix CONTRIBUTING.md 5/5 ❌ (`1`)
/repo/CONTRIBUTING.md
  1:0  error  Parsing error: Unexpected token (1:0)
✖ 1 problem (1 error, 0 warnings)
  • Check CI/CD configuration file
Sandbox logs for
pnpx prettier --write CI/CD configuration file 1/1 ❌ (`2`)
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
[error] No files matching the pattern were found: "CI/CD".
[error] No files matching the pattern were found: "configuration".
[error] No files matching the pattern were found: "file".
  • Check .github/workflows/ci.yml
Sandbox logs for
pnpx prettier --write .github/workflows/ci.yml 1/3 ✓
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
.github/workflows/ci.yml 33ms
pnpm eslint --fix .github/workflows/ci.yml 2/3 ✓
/repo/.github/workflows/ci.yml
  0:0  warning  File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern '!'") to override
✖ 1 problem (0 errors, 1 warning)
pnpx ts-node --type-check .github/workflows/ci.yml 3/3 ❌ (`1`)
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +20
++++++++++++++++++++
Progress: resolved 20, reused 17, downloaded 3, added 17
Progress: resolved 20, reused 17, downloaded 3, added 20, done
/repo/.github/workflows/ci.yml:1
# .github/workflows/ci.yml
^
SyntaxError: Invalid or unexpected token
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.require.extensions. [as .js] (/root/.local/share/pnpm/store/v3/tmp/dlx-113/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/index.ts:1608:43)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at phase4 (/root/.local/share/pnpm/store/v3/tmp/dlx-113/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/bin.ts:649:14)
    at bootstrap (/root/.local/share/pnpm/store/v3/tmp/dlx-113/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/bin.ts:95:10)
  • Check .github/workflows/ci.yml
Sandbox logs for
pnpx prettier --write .github/workflows/ci.yml 1/3 ✓
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
.github/workflows/ci.yml 31ms
pnpm eslint --fix .github/workflows/ci.yml 2/3 ✓
/repo/.github/workflows/ci.yml
  0:0  warning  File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern '!'") to override
✖ 1 problem (0 errors, 1 warning)
pnpx ts-node --type-check .github/workflows/ci.yml 3/3 ❌ (`1`)
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +20
++++++++++++++++++++
Progress: resolved 20, reused 17, downloaded 3, added 16
Progress: resolved 20, reused 17, downloaded 3, added 20, done
/repo/.github/workflows/ci.yml:1
# .github/workflows/ci.yml
^
SyntaxError: Invalid or unexpected token
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.require.extensions. [as .js] (/root/.local/share/pnpm/store/v3/tmp/dlx-112/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/index.ts:1608:43)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at phase4 (/root/.local/share/pnpm/store/v3/tmp/dlx-112/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/bin.ts:649:14)
    at bootstrap (/root/.local/share/pnpm/store/v3/tmp/dlx-112/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/bin.ts:95:10)
  • Check .github/workflows/ci.yml
Sandbox logs for
pnpx prettier --write .github/workflows/ci.yml 1/3 ✓
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
.github/workflows/ci.yml 33ms
pnpm eslint --fix .github/workflows/ci.yml 2/3 ✓
/repo/.github/workflows/ci.yml
  0:0  warning  File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern '!'") to override
✖ 1 problem (0 errors, 1 warning)
pnpx ts-node --type-check .github/workflows/ci.yml 3/3 ❌ (`1`)
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +20
++++++++++++++++++++
Progress: resolved 20, reused 17, downloaded 3, added 17
Progress: resolved 20, reused 17, downloaded 3, added 20, done
/repo/.github/workflows/ci.yml:1
# .github/workflows/ci.yml
^
SyntaxError: Invalid or unexpected token
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.require.extensions. [as .js] (/root/.local/share/pnpm/store/v3/tmp/dlx-113/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/index.ts:1608:43)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at phase4 (/root/.local/share/pnpm/store/v3/tmp/dlx-113/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/bin.ts:649:14)
    at bootstrap (/root/.local/share/pnpm/store/v3/tmp/dlx-113/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/ts-node/src/bin.ts:95:10)
  • Check CI/CD configuration file
Sandbox logs for
pnpx prettier --write CI/CD configuration file 1/1 ❌ (`2`)
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
[error] No files matching the pattern were found: "CI/CD".
[error] No files matching the pattern were found: "configuration".
[error] No files matching the pattern were found: "file".
  • Check CONTRIBUTING.md
Sandbox logs for
npm install -g pnpm 1/5 ✓
changed 1 package in 5s
1 package is looking for funding
  run `npm fund` for details
pnpm i 2/5 ✓
Scope: all 6 workspace projects
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1741
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 1741, reused 0, downloaded 39, added 30
Progress: resolved 1741, reused 0, downloaded 286, added 286
Progress: resolved 1741, reused 0, downloaded 613, added 610
Progress: resolved 1741, reused 0, downloaded 908, added 904
Progress: resolved 1741, reused 0, downloaded 1087, added 1079
Progress: resolved 1741, reused 0, downloaded 1294, added 1296
Progress: resolved 1741, reused 0, downloaded 1394, added 1392
Progress: resolved 1741, reused 0, downloaded 1446, added 1439
Progress: resolved 1741, reused 0, downloaded 1678, added 1667
Progress: resolved 1741, reused 0, downloaded 1737, added 1741, done
.../node_modules/core-js-pure postinstall$ node -e "try{require('./postinstall')}catch(e){}"
.../[email protected]/node_modules/core-js postinstall$ node -e "try{require('./postinstall')}catch(e){}"
.../node_modules/core-js-pure postinstall: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
.../node_modules/core-js-pure postinstall: The project needs your help! Please consider supporting core-js:
.../node_modules/core-js-pure postinstall: > https://opencollective.com/core-js 
.../node_modules/core-js-pure postinstall: > https://patreon.com/zloirock 
.../node_modules/core-js-pure postinstall: > https://boosty.to/zloirock 
.../node_modules/core-js-pure postinstall: > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz 
.../node_modules/core-js-pure postinstall: I highly recommend reading this: https://github.com/zloirock/core-js/blob/master/docs/2023-02-14-so-whats-next.md 
.../node_modules/core-js-pure postinstall: Done
.../[email protected]/node_modules/core-js postinstall: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
.../[email protected]/node_modules/core-js postinstall: The project needs your help! Please consider supporting core-js:
.../[email protected]/node_modules/core-js postinstall: > https://opencollective.com/core-js 
.../[email protected]/node_modules/core-js postinstall: > https://patreon.com/zloirock 
.../[email protected]/node_modules/core-js postinstall: > https://boosty.to/zloirock 
.../[email protected]/node_modules/core-js postinstall: > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz 
.../[email protected]/node_modules/core-js postinstall: I highly recommend reading this: https://github.com/zloirock/core-js/blob/master/docs/2023-02-14-so-whats-next.md 
.../[email protected]/node_modules/core-js postinstall: Done
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../[email protected]/node_modules/esbuild postinstall: Done
dependencies:
+ @changesets/cli 2.26.2
devDependencies:
+ @turbo/gen 1.10.16
+ @types/jest 29.5.6
+ eslint 8.52.0
+ eslint-config-custom 0.0.0 <- packages/eslint-config-custom
+ husky 8.0.3
+ jest 29.7.0
+ prettier 3.0.3
+ prettier-plugin-organize-imports 3.2.3
+ ts-jest 29.1.1
+ turbo 1.10.16
. prepare$ husky install
. prepare: husky - Git hooks installed
. prepare: Done
Done in 12.4s
pnpm add --save-dev prettier -w 3/5 ✓
Progress: resolved 0, reused 1, downloaded 0, added 0
Progress: resolved 133, reused 118, downloaded 0, added 0
Progress: resolved 448, reused 408, downloaded 0, added 0
Progress: resolved 1022, reused 988, downloaded 0, added 0
Progress: resolved 1769, reused 1735, downloaded 0, added 0
 WARN  3 deprecated subdependencies found: [email protected], [email protected], [email protected]
Packages: +8 -8
++++++++--------
Progress: resolved 1771, reused 1737, downloaded 0, added 8
Progress: resolved 1771, reused 1737, downloaded 0, added 8, done
Done in 7.4s
pnpx prettier --write CONTRIBUTING.md 4/5 ✓
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
CONTRIBUTING.md 51ms
pnpm eslint --fix CONTRIBUTING.md 5/5 ❌ (`1`)
/repo/CONTRIBUTING.md
  1:0  error  Parsing error: Unexpected token (1:0)
✖ 1 problem (1 error, 0 warnings)

Copy link
Contributor Author

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Oct 31, 2023
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 5:17pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Cannot install dependencies using pnpm
1 participant