Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental package + json query engine #613

Merged
merged 12 commits into from
Mar 7, 2024

Conversation

EmanuelCampos
Copy link
Contributor

@EmanuelCampos EmanuelCampos commented Mar 6, 2024

fixing types not being generated

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: f2495ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
llamaindex Patch
@llamaindex/experimental Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 1:18pm

@EmanuelCampos EmanuelCampos changed the title feat: experiemental package + json query engine feat: experimental package + json query engine Mar 6, 2024
@EmanuelCampos EmanuelCampos mentioned this pull request Mar 6, 2024
3 tasks
Copy link
Collaborator

@marcusschiesser marcusschiesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job - looks good to me!

@EmanuelCampos EmanuelCampos requested a review from himself65 March 6, 2024 13:17
@EmanuelCampos EmanuelCampos marked this pull request as ready for review March 6, 2024 15:24
package.json Outdated
@@ -14,6 +14,7 @@
"release": "pnpm run build:release && changeset publish",
"new-llamaindex": "pnpm run build:release && changeset version --ignore create-llama",
"new-create-llama": "pnpm run build:release && changeset version --ignore llamaindex --ignore @llamaindex/core-test",
"new-experimental": "pnpm run build:release && changeset version --ignore create-llama",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmanuelCampos this operation is then the same as new-llamaindex, you probably want to ignore more or leave it out (which would mean experimental versioning would depend on core)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh true hehe, mb

Comment on lines 49 to 50
"build:esm": "swc src -d dist --strip-leading-paths --config-file .swcrc",
"build:cjs": "swc src -d dist/cjs --strip-leading-paths --config-file .cjs.swcrc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmanuelCampos EmanuelCampos merged commit aefc326 into main Mar 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants