-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use sha256 hash value as the Document.id_
in MarkdownReader
#768
Conversation
`MarkdownReader` uses `randomUUID()` as the `Document.id_`, which invalidate `DocStoreStrategy.UPSERTS` and `DocStoreStrategy.UPSERTS_AND_DELETE`, check [here]https://github.com/run-llama/LlamaIndexTS/blob/74686f5776d4707815e1f3f761dabc5393b29779/packages/core/src/ingestion/strategies/classify.ts#L13)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Use `file[_suffix] as `Document.id_` in `MarkdownReader` and `PDFReader`
Could you please fix the lint issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @ezirmusitua - that looks good!
MarkdownReader
usesrandomUUID()
as theDocument.id_
, which invalidateDocStoreStrategy.UPSERTS
andDocStoreStrategy.UPSERTS_AND_DELETE
, check [here]LlamaIndexTS/packages/core/src/ingestion/strategies/classify.ts
Line 13 in 74686f5