Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sha256 hash value as the Document.id_ in MarkdownReader #768

Merged
merged 6 commits into from
May 7, 2024

Conversation

ezirmusitua
Copy link
Contributor

MarkdownReader uses randomUUID() as the Document.id_, which invalidate DocStoreStrategy.UPSERTS and DocStoreStrategy.UPSERTS_AND_DELETE, check [here]

const existingHash = await docStore.getDocumentHash(refDocId);
)

`MarkdownReader` uses `randomUUID()` as the `Document.id_`, which invalidate `DocStoreStrategy.UPSERTS` and `DocStoreStrategy.UPSERTS_AND_DELETE`, check [here]https://github.com/run-llama/LlamaIndexTS/blob/74686f5776d4707815e1f3f761dabc5393b29779/packages/core/src/ingestion/strategies/classify.ts#L13)
Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: 34a0edd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:27am

Use `file[_suffix] as `Document.id_` in `MarkdownReader` and `PDFReader`
@himself65
Copy link
Member

Could you please fix the lint issue?

Copy link
Collaborator

@marcusschiesser marcusschiesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ezirmusitua - that looks good!

@marcusschiesser marcusschiesser merged commit 645fcf6 into run-llama:main May 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants