fix(core): polyfill Web Stream APIs #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
himself65
changed the title
himself65
commented
Apr 28, 2024
himself65
commented
Apr 28, 2024
Comment on lines
+73
to
+80
| const output = stepOutput.output; | ||
| if (output instanceof ReadableStream) { | ||
| for await (const chunk of output) { | ||
| process.stdout.write(chunk.delta); | ||
| } | ||
| } else { | ||
| console.log(output); | ||
| } |
There was a problem hiding this comment.
This seems ugly to use, but since this not for user side API, I think it's okay for now
himself65
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feedback from: https://discord.com/channels/1059199217496772688/1133167189860565033/1233430729879453738
Reason is lower version typescript doesn't have built-in async iterator support for Readable Stream
This PR will restrict the type check by set
typesto empty array, and remove "DOM" on the top config to make sure each sub-module uses correct types