Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change <-> to <=> in the SELECT query #804

Merged
merged 2 commits into from
May 3, 2024

Conversation

JT-Dev-215
Copy link
Contributor

@JT-Dev-215 JT-Dev-215 commented May 3, 2024

The SQL is comparing the parameter vector with the embeddings column using "<=>" operator. "<->" is used for cosine distance calculation. The change now matches with the code in the Python package.

The SQL is comparing the parameter vector with the embeddings column using "<=>" operator. "<->" is used for vector distance calculations. The change now matches with the code in the Python package.
Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: ea6c3e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
llamaindex Patch
docs Patch
@llamaindex/experimental Patch
@llamaindex/cloudflare-worker-agent-test Patch
@llamaindex/next-agent-test Patch
@llamaindex/waku-query-engine-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 4:50pm

@himself65 himself65 changed the title Changed <-> to <=> in the SELECT query fix: change <-> to <=> in the SELECT query May 3, 2024
@himself65 himself65 merged commit e74fe88 into run-llama:main May 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants