fix(chart): Allow setting portName on service (#414)

* fix(chart): Allow setting portName on service
runatlantis · Aug 23, 2024 · ad4e155 · ad4e155
1 parent 38742fa
commit ad4e155
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 2 deletions.
diff --git a/charts/atlantis/Chart.yaml b/charts/atlantis/Chart.yaml
@@ -3,7 +3,7 @@ apiVersion: v1
 appVersion: v0.28.5
 description: A Helm chart for Atlantis https://www.runatlantis.io
 name: atlantis
-version: 5.4.4
+version: 5.4.5
 keywords:
   - terraform
 home: https://www.runatlantis.io

diff --git a/charts/atlantis/README.md b/charts/atlantis/README.md
@@ -184,6 +184,7 @@ extraManifests:
 | service.loadBalancerSourceRanges | list | `[]` |  |
 | service.nodePort | string | `nil` |  |
 | service.port | int | `80` |  |
+| service.portName | string | `"atlantis"` |  |
 | service.targetPort | int | `4141` |  |
 | service.type | string | `"NodePort"` |  |
 | serviceAccount.annotations | object | `{}` | Annotations for the Service Account. Check values.yaml for examples. |

diff --git a/charts/atlantis/templates/service.yaml b/charts/atlantis/templates/service.yaml
@@ -32,7 +32,7 @@ spec:
       nodePort: {{ .Values.service.nodePort }}
     {{- end }}
       protocol: TCP
-      name: atlantis
+      name: {{ .Values.service.portName }}
   selector:
     app: {{ template "atlantis.name" . }}
     release: {{ .Release.Name }}
diff --git a/charts/atlantis/tests/service_test.yaml b/charts/atlantis/tests/service_test.yaml
@@ -35,6 +35,14 @@ tests:
       - equal:
           path: spec.externalTrafficPolicy
           value: Local
+  - it: portName
+    set:
+      service:
+        portName: http-atlantis
+    asserts:
+      - equal:
+          path: spec.ports[0].name
+          value: http-atlantis
   - it: loadBalancerSourceRanges
     set:
       service:

diff --git a/charts/atlantis/values.schema.json b/charts/atlantis/values.schema.json
@@ -498,6 +498,13 @@
           ],
           "default": 80
         },
+        "portName": {
+          "description": "Port name to expose on the service.",
+          "type": [
+            "string"
+          ],
+          "default": "atlantis"
+        },
         "nodePort": {
           "description": "Port to expose on the node when the service type is NodePort.",
           "type": [

diff --git a/charts/atlantis/values.yaml b/charts/atlantis/values.yaml
@@ -286,6 +286,7 @@ service:
   type: NodePort
   annotations: {}
   port: 80
+  portName: atlantis
   nodePort: null
   targetPort: 4141
   loadBalancerIP: null