Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds bingo helper #6235

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

IronEvil478
Copy link

@IronEvil478 IronEvil478 commented Jul 2, 2024

A plugin to help support clan bingo events through runelite. This takes in a Json string defining all the items of the bingo and when one of the items is gained it will send a screenshot to discord through a web hook.

@runelite-github-app
Copy link

runelite-github-app bot commented Jul 2, 2024

@iProdigy
Copy link
Member

have you considered using an existing discord webhook plugin that supports arbitrary item allowlists?

@IronEvil478
Copy link
Author

So I looked through the hub filtered on the tag discord looking for something, I grabbed some honorable mentions but none matched the goal of a simple setup for the end user for clan events.
I looked at the following:

  1. https://runelite.net/plugin-hub/show/discord-screenshot
  2. https://runelite.net/plugin-hub/show/droptracker
  3. https://runelite.net/plugin-hub/show/clan-tracker
  4. https://runelite.net/plugin-hub/show/clan-chat-webhook
  5. https://runelite.net/plugin-hub/show/better-discord-loot-logger
  6. https://runelite.net/plugin-hub/show/universal-discord-notifications
  7. https://runelite.net/plugin-hub/show/dink

A common issue I came across was that the setup was super complex requiring changing in-game settings along with a number of plugin settings for some to function at all. Others had the issue that they were not tied to item names but rather everything over a value, this doesn't work great for the bingos my clan hosts and, as other items fall in price that could get that number rather low to catch all the barrows items(A common tile I've seen across many clan events).

If you have another plugin that matches the simplicity of a single string setup for everything or one that is simple to set-up with a fixed list of items I'm happy to look it over to use or maybe look to work on with said creator.

@iProdigy
Copy link
Member

iProdigy commented Jul 17, 2024

If you have another plugin that matches the simplicity of a single string setup for everything or one that is simple to set-up with a fixed list of items I'm happy to look it over to use or maybe look to work on with said creator.

dink supports an item allowlist and you can do ::dinkexport/::dinkimport to simplify sharing the setup, and it may be even easier once pajlads/DinkPlugin#488 is merged (disclosure: i'm a maintainer of that plugin)

of course, if dink doesn't meet your needs, creating a separate plugin can be reasonable

@Nightfirecat
Copy link
Member

Do you have any thoughts on prodigy's comment above? I'm happy to review this if it's still wanted, but if dink covers this use case sufficiently, I'm happy also for it to be a stand-in for this use case.

@IronEvil478
Copy link
Author

Do you have any thoughts on prodigy's comment above? I'm happy to review this if it's still wanted, but if dink covers this use case sufficiently, I'm happy also for it to be a stand-in for this use case.

I did have a long think on it, I’d like for it to be added with the custom messaging as well as the noting of what team the post is for. After I have the clan try it I do plan to expand it based around there feedback as well as any other clan that uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants