Skip to content

Commit

Permalink
chore: Update Go linter to v1.53.3 and resolve errors (#459)
Browse files Browse the repository at this point in the history
Issue #, if available:
N/A

*Description of changes:*
Updates golangci-lint in CI to v1.53.3 release and resolves linting
errors for unused arguments.

*Testing done:*
```make lint```

- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Austin Vazquez <[email protected]>
  • Loading branch information
austinvazquez authored Jun 29, 2023
1 parent e321f1d commit 4347ba7
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
# Pin the version in case all the builds start to fail at the same time.
# There may not be an automatic way (e.g., dependabot) to update a specific parameter of a Github Action,
# There may not be an automatic way (e.g., dependabot) to update a specific parameter of a GitHub Action,
# so we will just update it manually whenever it makes sense (e.g., a feature that we want is added).
version: v1.51.2
version: v1.53.3
args: --fix=false --timeout=5m
go-mod-tidy-check:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/support_bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func newGenerateSupportBundleAction(
}
}

func (gsa *generateSupportBundleAction) runAdapter(cmd *cobra.Command, args []string) error {
func (gsa *generateSupportBundleAction) runAdapter(cmd *cobra.Command, _ []string) error {
additionalFiles, err := cmd.Flags().GetStringArray("include")
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func newVersionAction(creator command.LimaCmdCreator, logger flog.Logger, stdOut
return &versionAction{creator: creator, logger: logger, stdOut: stdOut}
}

func (va *versionAction) runAdapter(cmd *cobra.Command, args []string) error {
func (va *versionAction) runAdapter(_ *cobra.Command, _ []string) error {
return va.run()
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/virtual_machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func newPostVMStartInitAction(
return &postVMStartInitAction{creator: creator, logger: logger, fs: fs, privateKeyPath: privateKeyPath, nca: nca}
}

func (p *postVMStartInitAction) runAdapter(cmd *cobra.Command, args []string) error {
func (p *postVMStartInitAction) runAdapter(_ *cobra.Command, _ []string) error {
return p.run()
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/virtual_machine_init.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func newInitVMAction(
}
}

func (iva *initVMAction) runAdapter(cmd *cobra.Command, args []string) error {
func (iva *initVMAction) runAdapter(_ *cobra.Command, _ []string) error {
return iva.run()
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/virtual_machine_remove.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func newRemoveVMAction(creator command.LimaCmdCreator, logger flog.Logger) *remo
return &removeVMAction{creator: creator, logger: logger}
}

func (rva *removeVMAction) runAdapter(cmd *cobra.Command, args []string) error {
func (rva *removeVMAction) runAdapter(cmd *cobra.Command, _ []string) error {
force, err := cmd.Flags().GetBool("force")
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/virtual_machine_start.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func newStartVMAction(
}
}

func (sva *startVMAction) runAdapter(cmd *cobra.Command, args []string) error {
func (sva *startVMAction) runAdapter(_ *cobra.Command, _ []string) error {
return sva.run()
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/virtual_machine_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func newStatusVMAction(creator command.LimaCmdCreator, logger flog.Logger, stdou
return &statusVMAction{creator: creator, logger: logger, stdout: stdout}
}

func (sva *statusVMAction) runAdapter(cmd *cobra.Command, args []string) error {
func (sva *statusVMAction) runAdapter(_ *cobra.Command, _ []string) error {
return sva.run()
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/finch/virtual_machine_stop.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func newStopVMAction(creator command.LimaCmdCreator, logger flog.Logger) *stopVM
return &stopVMAction{creator: creator, logger: logger}
}

func (sva *stopVMAction) runAdapter(cmd *cobra.Command, args []string) error {
func (sva *stopVMAction) runAdapter(cmd *cobra.Command, _ []string) error {
force, err := cmd.Flags().GetBool("force")
if err != nil {
return err
Expand Down

0 comments on commit 4347ba7

Please sign in to comment.