Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev containers functionality to finch #1095

Closed
wants to merge 0 commits into from

Conversation

Shubhranshu153
Copy link
Contributor

@Shubhranshu153 Shubhranshu153 commented Sep 17, 2024

Issue #, if available:

Description of changes:

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chews93319
Copy link
Contributor

chews93319 commented Sep 17, 2024

The commit ahead of this PR is significantly different and requires conflict resolution.
Also, I have identified the logical fallacy, which is failing the unit-tests and is at the center of the changes that you've shared.

I have started a revision/refactor that will reconcile both the core issues and the conflict resolution, which should surpass this PR.

@Shubhranshu153
Copy link
Contributor Author

rebased the branch, branch says mergable so you should be able to test it directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants