Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(fix): fix test steps for real this time #1107

Merged
merged 1 commit into from
Sep 23, 2024
Merged

ci(fix): fix test steps for real this time #1107

merged 1 commit into from
Sep 23, 2024
+25 −39

Conversation

pendo324
Copy link
Member

Issue #, if available:

Description of changes:

  • My last attempt to fix this (ci(fix): update conditions #1099) didn't work because of syntax issues (link to errors). Trying to fix it again. Unfortunately, last time I also included changes to code, so the "docs" workflow didn't actually run.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 self-assigned this Sep 20, 2024
@pendo324 pendo324 requested a review from a team as a code owner September 20, 2024 19:56
@pendo324 pendo324 closed this Sep 20, 2024
@pendo324 pendo324 reopened this Sep 20, 2024
@pendo324 pendo324 closed this Sep 20, 2024
@pendo324 pendo324 reopened this Sep 20, 2024
@pendo324 pendo324 merged commit 346ac72 into runfinch:main Sep 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezar-r cezar-r cezar-r approved these changes

@coderbirju coderbirju Awaiting requested review from coderbirju

@austinvazquez austinvazquez Awaiting requested review from austinvazquez

Assignees

@pendo324 pendo324

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pendo324 @cezar-r