Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(linux): DOCKER_CONFIG path (#1102) #1110

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

pendo324
Copy link
Member

This reverts commit 5b45b75.

Issue #, if available:

Description of changes:

  • Reverting fix(linux): DOCKER_CONFIG path #1102 because the soci-snapshotter service does not use DOCKER_CONFIG passed by clients to get credentials. Customizing the directory causes SOCI to not find credentials at the default path, which causes performance regressions.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This reverts commit 5b45b75.

Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 self-assigned this Sep 23, 2024
@pendo324 pendo324 merged commit 839221c into runfinch:main Sep 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants