Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add generate log files and upload to S3 bucket #1194

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

sky1122
Copy link
Contributor

@sky1122 sky1122 commented Nov 20, 2024

  • add upload to S3 bucket

    • e2e-linux.yaml
    • e2e-macos.yaml
    • e2e-windows.yaml
  • generate test log report while running the e2e testing

Makefile

  • [ X] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sky1122 sky1122 marked this pull request as ready for review November 27, 2024 17:01
@sky1122 sky1122 requested a review from a team as a code owner November 27, 2024 17:01
@sky1122 sky1122 force-pushed the ci-e2e-testing branch 2 times, most recently from 3d47915 to c44fe8f Compare December 2, 2024 19:58
@sky1122 sky1122 requested a review from austinvazquez December 9, 2024 18:44
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but one question do we want to have reports generated on every pull request? Does it make sense to limit it to merges to mainline and nightly runs?

.github/workflows/e2e-macos.yaml Outdated Show resolved Hide resolved
@sky1122 sky1122 requested a review from a team as a code owner December 16, 2024 21:52
@sky1122 sky1122 force-pushed the ci-e2e-testing branch 3 times, most recently from 379dcc7 to d197701 Compare December 17, 2024 01:50
@sky1122 sky1122 requested review from austinvazquez and removed request for austinvazquez December 18, 2024 21:55
austinvazquez
austinvazquez previously approved these changes Dec 31, 2024
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI pass.

@austinvazquez
Copy link
Member

Just a note for other maintainers, spoke with @sky1122 offline. The current approach is not viable due to test workflows taking longer than the token lifetime for publishing to AWS S3. @sky1122 is working to increment the implementation to split generating reports and publishing to S3 are seperate jobs.

@austinvazquez
Copy link
Member

For some reason the jobs are not running as expected because it is running ci-docs.yaml workflow.

@austinvazquez
Copy link
Member

Found the issue. The CI workflow is having a parsing error. See https://github.com/runfinch/finch/actions/runs/12637567164

@sky1122 sky1122 force-pushed the ci-e2e-testing branch 2 times, most recently from 465d092 to b644cb7 Compare January 7, 2025 18:14
@sky1122 sky1122 requested a review from austinvazquez January 8, 2025 18:19
.github/workflows/e2e-macos.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-macos.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-windows.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-macos.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-windows.yaml Outdated Show resolved Hide resolved
Signed-off-by: Jingwei Wang <[email protected]>

fix Amazon Linux if condition

Signed-off-by: Jingwei Wang <[email protected]>

ci: only merges to mainline and nightly runs will generate log reports

Signed-off-by: Jingwei Wang <[email protected]>

Squashed commit message for the first 10 commits

Signed-off-by: Jingwei Wang <[email protected]>

fix minor errors

Signed-off-by: Jingwei Wang <[email protected]>

fix minor errors

Signed-off-by: Jingwei Wang <[email protected]>

fix minor errors

Signed-off-by: Jingwei Wang <[email protected]>

fix minor errors

Signed-off-by: Jingwei Wang <[email protected]>

fix minor errors

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test2

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test3

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test4

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test5

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test-windows

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test-windows2

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test-windows3

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test-windows4

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test-windows5

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test-windows6

Signed-off-by: Jingwei Wang <[email protected]>

seprate CI jobs test1

Signed-off-by: Jingwei Wang <[email protected]>

fix: duplicate uploading

Signed-off-by: Jingwei Wang <[email protected]>

fix: change job name and use sha to include actions
Signed-off-by: Jingwei Wang <[email protected]>
@austinvazquez austinvazquez merged commit 1f14f16 into main Jan 10, 2025
61 checks passed
@austinvazquez austinvazquez deleted the ci-e2e-testing branch January 10, 2025 23:39
austinvazquez added a commit to austinvazquez/finch that referenced this pull request Jan 13, 2025
austinvazquez added a commit to austinvazquez/finch that referenced this pull request Jan 13, 2025
austinvazquez added a commit to austinvazquez/finch that referenced this pull request Jan 13, 2025
austinvazquez added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants