-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add generate log files and upload to S3 bucket #1194
Conversation
d329684
to
099c8b1
Compare
3d47915
to
c44fe8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but one question do we want to have reports generated on every pull request? Does it make sense to limit it to merges to mainline and nightly runs?
379dcc7
to
d197701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on CI pass.
d197701
to
d274fe8
Compare
Just a note for other maintainers, spoke with @sky1122 offline. The current approach is not viable due to test workflows taking longer than the token lifetime for publishing to AWS S3. @sky1122 is working to increment the implementation to split generating reports and publishing to S3 are seperate jobs. |
3151a62
to
10b6fd0
Compare
For some reason the jobs are not running as expected because it is running ci-docs.yaml workflow. |
Found the issue. The CI workflow is having a parsing error. See https://github.com/runfinch/finch/actions/runs/12637567164 |
465d092
to
b644cb7
Compare
Signed-off-by: Jingwei Wang <[email protected]> fix Amazon Linux if condition Signed-off-by: Jingwei Wang <[email protected]> ci: only merges to mainline and nightly runs will generate log reports Signed-off-by: Jingwei Wang <[email protected]> Squashed commit message for the first 10 commits Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test2 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test3 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test4 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test5 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test-windows Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test-windows2 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test-windows3 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test-windows4 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test-windows5 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test-windows6 Signed-off-by: Jingwei Wang <[email protected]> seprate CI jobs test1 Signed-off-by: Jingwei Wang <[email protected]> fix: duplicate uploading Signed-off-by: Jingwei Wang <[email protected]> fix: change job name and use sha to include actions Signed-off-by: Jingwei Wang <[email protected]>
b644cb7
to
ba2477c
Compare
…1194)" This reverts commit 1f14f16. Signed-off-by: Austin Vazquez <[email protected]>
…#1194)" This reverts commit 1f14f16. Signed-off-by: Austin Vazquez <[email protected]>
…1243) This reverts commit 1f14f16. Signed-off-by: Austin Vazquez <[email protected]>
add upload to S3 bucket
generate test log report while running the e2e testing
Makefile
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.