Replaced ssh with https protocol when cloning the repository #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #155
Description of changes:
Replaced SSH with HTTPS protocol within the "Running containers and building images" instructions
Testing done:
➜ GIT git clone https://github.com/runfinch/finch.git
cd finch/contrib/hello-finch
finch build . -t hello-finch
finch run --rm hello-finch
Cloning into 'finch'...
remote: Enumerating objects: 767, done.
remote: Counting objects: 100% (765/765), done.
remote: Compressing objects: 100% (310/310), done.
remote: Total 767 (delta 474), reused 686 (delta 438), pack-reused 2
Receiving objects: 100% (767/767), 367.74 KiB | 5.49 MiB/s, done.
Resolving deltas: 100% (474/474), done.
[+] Building 1.4s (11/11) FINISHED
=> [internal] load .dockerignore 0.1s
=> => transferring context: 2B 0.0s
=> [internal] load build definition from Dockerfile 0.2s
=> => transferring dockerfile: 270B 0.1s
=> [internal] load metadata for public.ecr.aws/docker/library/golang:1.19 0.8s
=> [builder 1/4] FROM public.ecr.aws/docker/library/golang:1.19@sha256:bb9811fad43a7d6fd2173248d8331b2dcf5ac9af20976b1937ecd214c5b8c383 0.1s
=> => resolve public.ecr.aws/docker/library/golang:1.19@sha256:bb9811fad43a7d6fd2173248d8331b2dcf5ac9af20976b1937ecd214c5b8c383 0.1s
=> [internal] load build context 0.1s
=> => transferring context: 2.11kB 0.0s
=> CACHED [builder 2/4] WORKDIR /build 0.0s
=> CACHED [builder 3/4] COPY . . 0.0s
=> CACHED [builder 4/4] RUN CGO_ENABLED=0 go build -a -o hello-finch . 0.0s
=> CACHED [stage-1 1/2] COPY --from=builder /build/hello-finch /app/ 0.0s
=> CACHED [stage-1 2/2] WORKDIR /app 0.0s
=> exporting to image 0.1s
=> => exporting layers 0.0s
=> => exporting manifest sha256:9f5cf180d2edd0453c6fbd6e9498f3eefefeafbe1a3bc5b03a3b837d72a6e6d4 0.0s
=> => exporting config sha256:f8432af0c5e1b4e2ca06060199bd50a3aa36d56ab0176ea88053143c88e9941c 0.0s
=> => naming to docker.io/library/hello-finch:latest 0.0s
=> => unpacking to docker.io/library/hello-finch:latest 0.0s
Hello from Finch!
Visit us @ github.com/runfinch
(otel-getting-started) ➜ hello-finch git:(main)
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.