fix: Add aws cli to system path #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky1122
force-pushed
the
addEnvPathVariable
branch
from
11933d8
to
dbb4c7b
Compare
pendo324
reviewed
Nov 21, 2024
Comment on lines
68
to
82
| # Add AWS CLI to PATH | ||
| $awsPath = Get-Command aws -ErrorAction SilentlyContinue | Select-Object -ExpandProperty Source | ||
| if ($awsPath) { | ||
| $awsDir = Split-Path -Parent $awsPath | ||
| $currentPath = [Environment]::GetEnvironmentVariable("Path", "Machine") | ||
| if ($currentPath -notlike "*$awsDir*") { | ||
| $newPath = "$currentPath;$awsDir" | ||
| [Environment]::SetEnvironmentVariable("Path", $newPath, "Machine") | ||
| Write-Output "AWS CLI path added to system PATH: $awsDir" | ||
| } else { | ||
| Write-Output "AWS CLI path already in system PATH" | ||
| } | ||
| } else { | ||
| Write-Output "AWS CLI not found" | ||
| } |
There was a problem hiding this comment.
Do we really need all this logic? If the MSI installation succeeds, we can assume the AWS binary is at the default path.
There was a problem hiding this comment.
Yes, the default path is C:\Program Files\Amazon\AWSCLIV2\aws.
$awsPath = "C:\Program Files\Amazon\AWSCLIV2"
$currentPath = [Environment]::GetEnvironmentVariable("Path", "Machine")
$newPath = "$currentPath;$awsPath"
[Environment]::SetEnvironmentVariable("Path", $newPath, "Machine")
Can I change to this? or can we use C:\Program Files\Amazon\AWSCLIV2\aws to call the aws cli?
Comment on lines
62
to
66
| # Install AWS CLI | ||
| Invoke-WebRequest -Uri https://awscli.amazonaws.com/AWSCLIV2.msi -OutFile AWSCLIV2.msi | ||
| Start-Process msiexec.exe -Wait -ArgumentList '/I AWSCLIV2.msi /quiet' | ||
| aws --version | ||
| Remove-Item AWSCLIV2.msi |
There was a problem hiding this comment.
Need to merge/rebase from main to remove this from the diff. It's causing a merge conflict.
Signed-off-by: jingwei wang <[email protected]>
sky1122
force-pushed
the
addEnvPathVariable
branch
from
dbb4c7b
to
f0cc8e5
Compare
Signed-off-by: jingwei wang <[email protected]>
sky1122
force-pushed
the
addEnvPathVariable
branch
from
f0cc8e5
to
2139b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix cannot directly use aws cli in command line
Testing done:
have a windows instance and using windows app test the power shell command
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.