-
Notifications
You must be signed in to change notification settings - Fork 26
Pin v2 dependency versions for reproducibility #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
conorbronsdon
wants to merge
1
commit into
rungalileo:main
from
conorbronsdon:chore/pin-v2-dependencies
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| galileo | ||
| langchain | ||
| langchain_anthropic | ||
| langchain_baseten | ||
| langchain_openai | ||
| langchain_mistralai | ||
| langchain_google_genai | ||
| langchain_together | ||
| langchain_fireworks | ||
| langchain_writer | ||
| langchain_deepseek | ||
| langchain_aws | ||
| langchain_nvidia_ai_endpoints | ||
| langchain_cohere | ||
| colorama | ||
| pandas | ||
| langchain-xai | ||
| tqdm | ||
| pydantic | ||
| galileo>=1.49.0 | ||
| langchain>=1.2.0 | ||
| langchain-anthropic>=1.3.0 | ||
| langchain-baseten>=0.1.9 | ||
| langchain-openai>=1.1.0 | ||
| langchain-mistralai>=1.1.0 | ||
| langchain-google-genai>=4.2.0 | ||
| langchain-together>=0.3.0 | ||
| langchain-fireworks>=1.1.0 | ||
| langchain-writer>=0.3.5 | ||
| langchain-deepseek>=1.0.0 | ||
| langchain-aws>=1.4.0 | ||
| langchain-nvidia-ai-endpoints>=1.2.0 | ||
| langchain-cohere>=0.5.0 | ||
| langchain-xai>=1.2.0 | ||
| colorama>=0.4.6 | ||
| pandas>=2.2.0 | ||
| tqdm>=4.67.0 | ||
| pydantic>=2.10.0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2 requirements use minimum-bound specifiers (e.g.
galileo>=1.49.0) instead of exact pins, so pip can install newer/unbounded versions and installs remain non-deterministic; the PR's reproducibility goal is not met. Can we pin each dependency with==or add a lockfile/constraints file?Finding type:
Logical Bugs| Severity: 🔴 HighWant Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally using >= rather than == here. The previous requirements had zero version constraints, so >= is already a big improvement. Exact pins in requirements.txt cause unnecessary dependency conflicts for contributors and downstream users. If the project adopts uv or pip-tools later, a lockfile can layer on top of these minimum bounds for CI reproducibility without constraining end users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood on preferring minimum bounds with >= here to reduce conflicts and rely on a future lockfile for reproducibility; I’ll save this preference to memory after the PR is merged.